[TYPO3-core] RFC #7909: Code cleanup: PHP5ize t3lib_iconworks to bring in line with it's documentation.

[Kasper Ligaard]

This is an SVN patch request.
        
Type: Code cleanup

Bugtracker references: http://bugs.typo3.org/view.php?id=7909
        
Branches: TYPO3_4-2

Problem:
In the documentation for t3lib_iconworks it states:

ALL functions called without making a class instance, eg.
"t3lib_iconWorks::getIconImage()"
        
Now that we have PHP5 as a minimum we should make the function in
t3lib_iconworks 'public static'. 

Solution:
- The attached patch adds 'public static' to all the function of
t3lib_iconworks.
- It marks the class final
- It replaces tabs between function declarations and '{' with a space.
- It inserts spaces where appropriate around = and after commas.
        
Notes:
- I know Typo3 does not use E_STRICT, but I still think the proposed
change would benefit all.
- This patch request is similar to
http://bugs.typo3.org/view.php?id=7350
- This patch is very similar to http://bugs.typo3.org/view.php?id=7903
- This patch is very similar to http://bugs.typo3.org/view.php?id=7906
        
Regards, Kasper
-------------- next part --------------
A non-text attachment was scrubbed...
Name: public-static-t3lib_iconworks.patch
Type: text/x-patch
Size: 15682 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080319/a25e30ec/attachment.bin