[TYPO3-core] RFC: #7860: Coloring in TS Object Browser depends on "Crop Lines"

[Steffen Kamper]

"Martin Kutschker" <martin.kutschker-n0spam at no5pam-blackbox.net> schrieb im 
Newsbeitrag 
news:mailman.1.1205879814.17672.typo3-team-core at lists.netfielders.de...
>
> No it doesn't.
>
> The cropping is done when the values have still the constant markers (eg
> ##6fb6de_B##) applied to it. So a large constant may loose it's closing
> marker, which will lead to a missing, yikes, closing font tag.
>
> A solution is to check if a value has crop markers like that in
> t3lib/class.t3lib_tsparser_ext.php:
>
> if (strncmp($theValue,'##'.$this->Cmarker.'_B##',12)) {
>  $theValue = $this->ext_fixed_lgd($theValue,$lgdChars);
> } else {
>   // crop "real" value and re-apply constant markers
>  $theValue =
> '##'.$this->Cmarker.'_B##'.$this->ext_fixed_lgd(substr($theValue,12,-12),$lgdChars).'##'.$this->Cmarker.'_E##';
> }
>
> This worked for me but is a bit whacky. OTOH the crop feature isn't very
> clean implemented itself.
>
> Masi
>
> PS: t3lib/class.t3lib_tsparser_ext.php::ext_fixed_lgd() is buggy as it
> doesn't use use t3lib_cs->crop or t3lib_div::fixed_lgd_cs() for
> cropping. UTF-8 characters may be destroyed!

right,  i didn't looked to htmlsource.

So i followed your proposal. I changed it only in function ext_fixed_lgd, 
see attached patch.

i hope to be right that also with utf8 the marker-length is 12,
the cropping i did with t3lib_div::fixed_lgd_cs() .
What is missing is a tooltip for the tags and replacing font-tags with span. 
There are also <br>s in it, but this has to be cleaned in 4.3

vg  Steffen 


begin 666 7860_tsobjbrowser_coloring_croplines2.diff
M26YD97 at Z('0S;&EB+V-L87-S+G0S;&EB7W1S<&%R<V5R7V5X="YP:' -"CT]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T-"BTM+2!T,VQI8B]C;&%S<RYT,VQI8E]T
M<W!A<G-E<E]E>'0N<&AP"2AR979I<VEO;B S-#4V*0T**RLK('0S;&EB+V-L
M87-S+G0S;&EB7W1S<&%R<V5R7V5X="YP:' )*'=O<FMI;F<@8V]P>2D-"D! 
M("TV.3<L-R K-CDW+#$Q($! #0H@"69U;F-T:6]N(&5X=%]F:7AE9%]L9V0H
M)'-T<FEN9RPD8VAA<G,I"7L*( D):68@*"1C:&%R<R ^/2 T*0E["B )"0EI
M9BAS=')L96XH)'-T<FEN9RD^)&-H87)S*2 @>PHM"0D)"7)E='5R;B!S=6)S
M='(H)'-T<FEN9RP@,"P@)&-H87)S+3,I+B<N+BXG.PHK"0D)"6EF*'-T<FQE
M;B at D<W1R:6YG*3XR-" F)B!S=6)S='(H)'-T<FEN9RPP+#$R*2 ]/2 G(R,G
M+B1T:&ES+3Y#;6%R:V5R+B=?0B,C)RD@>PHK"0D)"0ER971U<FX@)R,C)RXD
M=&AI<RT^0VUA<FME<BXG7T(C(R<N=#-L:6)?9&EV.CIF:7AE9%]L9V1?8W,H
M<W5B<W1R*"1S=')I;F<L,3(L+3$R*2P@)&-H87)S+3,I+B<C(R<N)'1H:7,M
M/D-M87)K97(N)U]%(R,G.PHK"0D)"7T at 96QS92!["BL)"0D)"7)E='5R;B!T
M,VQI8E]D:78Z.F9I>&5D7VQG9%]C<R at D<W1R:6YG+" D8VAA<G,M,RD["BL)
M"0D)?0H@"0D)?0H@"0E]"B )"7)E='5R;B D<W1R:6YG.PI);F1E>#H@='EP
M;S,O<WES97AT+W1S=&5M<&QA=&5?;V)J8G)O=W-E<B]C;&%S<RYT>%]T<W1E
M;7!L871E;V)J8G)O=W-E<BYP:' -"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T-
M"BTM+2!T>7!O,R]S>7-E>'0O='-T96UP;&%T95]O8FIB<F]W<V5R+V-L87-S
M+G1X7W1S=&5M<&QA=&5O8FIB<F]W<V5R+G!H< DH<F5V:7-I;VX@,S0U-BD-
M"BLK*R!T>7!O,R]S>7-E>'0O='-T96UP;&%T95]O8FIB<F]W<V5R+V-L87-S
M+G1X7W1S=&5M<&QA=&5O8FIB<F]W<V5R+G!H< DH=V]R:VEN9R!C;W!Y*0T*
M0$ @+3(Y,RPW("LR.3,L-R! 0 T*( D))'1M<&PM/FUA=&-H06QT97)N871I
M=F4@/2 D=&AI<RT^<$]B:BT^34]$7U-%5%1)3D=36R=T<V)R;W=S97)?8V]N
M9&ET:6]N<R==.PH@"0DD=&UP;"T^;6%T8VA!;'1E<FYA=&EV95M=(#T@)V1U
M;6UY9'5M;7ED=6UM>61U;6UY9'5M;7ED=6UM>61U;6UY9'5M;7ED=6UM>61U
M;6UY9'5M;7DG.PDO+R!4:&ES(&ES(&IU<W0@:&5R92!T;R!M86ME('-U<F4@
M=&AA="!A="!L96%S="!O;F4 at 96QE;65N="!I<R!I;B!T:&4 at 87)R87D@<V\@
M=&AA="!T:&4@='-P87)S97(@86-T=6%L;'D@=7-E<R!T:&ES(&%R<F%Y('1O
M(&UA=&-H+ at H@"BT)"21T;7!L+3YC;VYS=&%N=$UO9&4@/2 D=&AI<RT^<$]B
M:BT^34]$7U-%5%1)3D=36R)T<U]B<F]W<V5R7V9I>&5D3&=D(ET@/R B(B Z
M("1T:&ES+3YP3V)J+3Y-3T1?4T545$E.1U-;(G1S7V)R;W=S97)?8V]N<W0B
M73L**PD))'1M<&PM/F-O;G-T86YT36]D92 ]("1T:&ES+3YP3V)J+3Y-3T1?
M4T545$E.1U-;(G1S7V)R;W=S97)?8V]N<W0B73L*( D):68@*"1T:&ES+3YP
M3V)J+3YS3V)J("8F("1T;7!L+3YC;VYS=&%N=$UO9&4I"7LD=&UP;"T^8V]N
M<W1A;G1-;V1E(#T@(G5N=&]U8VAE9"([?0H@"B )"21T;7!L+3YR96=E>$UO
M9&4@/2 D=&AI<RT^<$]B:BT^34]$7U-%5%1)3D=36R)T<U]B<F]W<V5R7W)E
M9V5X<V5A<F-H(ET["D! ("TU,3<L-R K-3$W+#@@0$ -"B )"0DD;65N=2 ]
M("<\;&%B96P at 9F]R/2)C:&5C:U1S7V)R;W=S97)?9FEX961,9V0B/D-R;W @
M;&EN97,Z/"]L86)E;#X@)RYT,VQI8E]"169U;F,Z.F=E=$9U;F-#:&5C:R at D
M=&AI<RT^<$]B:BT^:60L(E-%5%MT<U]B<F]W<V5R7V9I>&5D3&=D72(L)'1H
M:7,M/G!/8FHM/DU/1%]3151424Y'4ULB='-?8G)O=W-E<E]F:7AE9$QG9")=
M+"<G+"<G+"=I9#TB8VAE8VM4<U]B<F]W<V5R7V9I>&5D3&=D(B<I.PH@"0D)
M)&UE;G4 at +CT@)SQB<B O/CQL86)E;"!F;W(](F-H96-K5'-?8G)O=W-E<E]S
M:&]W0V]M;65N=',B/D1I<W!L87D at 8V]M;65N=',Z/"]L86)E;#X@)RYT,VQI
M8E]"169U;F,Z.F=E=$9U;F-#:&5C:R at D=&AI<RT^<$]B:BT^:60L)U-%5%MT
M<U]B<F]W<V5R7W-H;W=#;VUM96YT<UTG+"1T:&ES+3YP3V)J+3Y-3T1?4T54
M5$E.1U-;)W1S7V)R;W=S97)?<VAO=T-O;6UE;G1S)UTI.PH@"0D))&UE;G4@
M+CT@)SQB<B O/CQL86)E;"!F;W(](F-H96-K5'-?8G)O=W-E<E]A;'!H85-O
M<G0B/E-O<G0 at 86QP:&%B971I8V%L;'DZ/"]L86)E;#X@)RYT,VQI8E]"169U
M;F,Z.F=E=$9U;F-#:&5C:R at D=&AI<RT^<$]B:BT^:60L)U-%5%MT<U]B<F]W
M<V5R7V%L<&AA4V]R=%TG+"1T:&ES+3YP3V)J+3Y-3T1?4T545$E.1U-;)W1S
M7V)R;W=S97)?86QP:&%3;W)T)UTL)R<L)R<L)VED/2)C:&5C:U1S7V)R;W=S
M97)?86QP:&%3;W)T(B<I.PHM"0D):68@*"1B5'EP93T](G-E='5P(B F)B A
M)'1H:7,M/G!/8FHM/DU/1%]3151424Y'4ULB='-?8G)O=W-E<E]F:7AE9$QG
M9")=*0E["BL)"0HK"0D):68@*"1B5'EP93T](G-E='5P(BD)>PH@"0D)"21M
M96YU+CT@(CQB<B O/D-O;G-T86YT<R!D:7-P;&%Y.B B+G0S;&EB7T)%9G5N
M8SHZ9V5T1G5N8TUE;G4H)'1H:7,M/G!/8FHM/FED+")3151;='-?8G)O=W-E
M<E]C;VYS=%TB+"1T:&ES+3YP3V)J+3Y-3T1?4T545$E.1U-;(G1S7V)R;W=S
M97)?8V]N<W0B72PD=&AI<RT^<$]B:BT^34]$7TU%3E5;(G1S7V)R;W=S97)?
M8V]N<W0B72D["B )"0E]"B )"0DD=&AE3W5T<'5T+CTD=&AI<RT^<$]B:BT^
K9&]C+3YS96-T:6]N*"(B+"<\3D]"4CXG+B1M96YU+B<\+TY/0E(^)RD["@``
`
end