[TYPO3-core] Reminder: RFC: Bugfix #4186 GIFBUILDER cropsized images have bad quality

[Steffen Kamper]

Hi,

this patch seems to be forgetten, it's in the list since begin of January, 
has 4 reminders and it's imho an important one.
So i bring it up here again and hope for ack and voting.

Background: Cropscale is a technique that is very useful to present 
different images with the same size. The feature in stdgraphics works, but 
produce bad quality. This is not only subjective feeling, also my clients 
recognized that and asked all the time for better quality.
So i use this patch for a long time (since 4.0-branch) and it works great.

As the patch is very simple, please test and vote. For testing make a simple 
Testobject like this:
lib.testimg = IMAGE
lib.testimg {
  file = fileadmin/maxy.jpg
  file {
    width  = 350c
    height = 300c - 50
  }
}

View Output in FE, then apply patch and refresh, difference is incredible.

vg  Steffen 


begin 666 bug_4186_cropscale_V2.diff
M26YD97 at Z('0S;&EB+V-L87-S+G0S;&EB7W-T9&=R87!H:6,N<&AP#0H]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]#0HM+2T@=#-L:6(O8VQA<W,N=#-L:6)?<W1D
M9W)A<&AI8RYP:' )*')E=FES:6]N(#,P-S0I#0HK*RL@=#-L:6(O8VQA<W,N
M=#-L:6)?<W1D9W)A<&AI8RYP:' )*'=O<FMI;F<@8V]P>2D-"D! ("TR,3<P
M+#8@*S(Q-S L,3, at 0$ -"B )"0D)"21P87)A;7,@/2 D=&AI<RT^8VUD<ULD
M;F5W17AT73L-"B )"0D)?0T*( T**PD)"0D)+R\@0W)O<'-C86QI;F<Z#0HK
M( D)"0EI9B H)&1A=&%;)V-R<R==*0E[#0HK"0D)"0DD;V98(#T@:6YT=F%L
M*"@D9&%T85LP72 M("1D871A6R=O<FEG5R==*2 J("@D9&%T85LG8W)O<$@G
M72LQ,# I+S(P,"D[#0HK"0D)"0DD;V99(#T@:6YT=F%L*"@D9&%T85LQ72 M
M("1D871A6R=O<FEG2"==*2 J("@D9&%T85LG8W)O<%8G72LQ,# I+S(P,"D[
M#0HK"0D)"0DD<&%R86US("X]("<@+6-R;W @)RXD9&%T85LG;W)I9U<G72XG
M>"<N)&1A=&%;)V]R:6=()UTN)RLG+B1O9E at N)RLG+B1O9EDN)R$@)SL-"BL)
M"0D)?0T**PT*( D)"0DD8V]M;6%N9" ]("1T:&ES+3YS8V%L96-M9"XG("<N
M)&EN9F];,%TN)W at G+B1I;F9O6S%=+B<A("<N)'!A<F%M<RXG("<[#0H@"0D)
M"21C<F]P<V-A;&4@/2 H)&1A=&%;)V-R<R==(#\@)V-R<RU6)RXD9&%T85LG
M8W)O<%8G72XG2"<N)&1A=&%;)V-R;W!()UT at .B G)RD[#0H@#0I 0" M,C$Y
M,"PS,B K,C$Y-RPW($! #0H@"0D)"0DO+R!296=I<W1E<B!T96UP;W)A<GD@
M9FEL96YA;64Z#0H@"0D)"21'3$]"04Q36R=414U07TE-04=%4U]/3E]004=%
M)UU;72 ]("1O=71P=70[#0H@#0HM"0D)"0DO+R!#<F]P<V-A;&EN9SH-"BT)
M"0D):68@*"1D871A6R=C<G,G72D)>PT*+0D)"0D):68@*"1T:&ES+3YD;VYT
M0VAE8VM&;W)%>&ES=&EN9U1E;7!&:6QE('Q\("$D=&AI<RT^9FEL95]E>&ES
M='-?='EP;S-T96UP7V9I;&4H)&]U='!U="P@)&EM86=E9FEL92DI"7L-"BT)
M"0D)"0DD8W)S3W5T<'5T(#T@<W1R7W)E<&QA8V4H)W!I8W,O)RP@)W!I8W,O
M8W)S+2<L("1O=71P=70I.PT*+0D)"0D)"21T:&ES+3YI;6%G94UA9VEC:T5X
M96,H)&EM86=E9FEL92XD9G)A;64L("1C<G-/=71P=70L("1C;VUM86YD*3L-
M"BT)"0D)"0DD9VEF0W)E871O<B ]('0S;&EB7V1I=CHZ;6%K94EN<W1A;F-E
M*"=T<VQI8E]G:69B=6EL9&5R)RD[#0HM"0D)"0D))&=I9D-R96%T;W(M/FEN
M:70H*3L-"BT)"0D)"0EI9B H)$=,3T)!3%-;)U194$\S7T-/3D9?5D%24R==
M6R='1E at G75LG9V1L:6(G72 A/3T@,"D)>PT*+0D)"0D)"0EI9B H(21D871A
M6R=O<FEG5R==*2![("1D871A6R=O<FEG5R==(#T@)&1A=&%;,%T[('T-"BT)
M"0D)"0D):68@*"$D9&%T85LG;W)I9T at G72D@>R D9&%T85LG;W)I9T at G72 ]
M("1D871A6S%=.R!]#0HM"0D)"0D)"21O9E@@/2!I;G1V86PH*"1D871A6R=O
M<FEG5R==("T@)&1A=&%;,%TI("H@*"1D871A6R=C<F]P2"==*S$P,"DO,C P
M*3L-"BT)"0D)"0D))&]F62 ](&EN='9A;"@H)&1A=&%;)V]R:6=()UT at +2 D
M9&%T85LQ72D@*B H)&1A=&%;)V-R;W!6)UTK,3 P*2\R,# I.PT*+0D)"0D)
M"0DD=&UP4&%R;2 ]($%R<F%Y*"=862<@/3X@:6YT=F%L*"1D871A6R=O<FEG
M5R==*2XG+"<N:6YT=F%L*"1D871A6R=O<FEG2"==*2P-"BT)"0D)"0D)"0DG
M,3 G(#T^("=)34%'12<L#0HM"0D)"0D)"0D))S$P+B<@/3X at 87)R87DH)V9I
M;&4G/3X@)&-R<T]U='!U="P@)V]F9G-E="<]/B D;V98+B<L)RXD;V99*2P-
M"BT)"0D)"0D)*3L-"BT)"0D)"0D))&=I9D-R96%T;W(M/G-T87)T*"1T;7!0
M87)M+"!A<G)A>2 at I*3L-"BT)"0D)"0D))&YE=V]U='!U=" ]("1G:69#<F5A
M=&]R+3YG:69"=6EL9"@I.PT*+0D)"0D)"0EI9B H(6-O<'DH)&YE=V]U='!U
M="PD;W5T<'5T*2D@>PT*+0D)"0D)"0D))&]U='!U=" ]("1N97=O=71P=70[
M#0HM"0D)"0D)"7T-"BT)"0D)"0E](&5L<V4@>PT*+0D)"0D)"0DD;W5T<'5T
M(#T@)&-R<T]U='!U=#L-"BT)"0D)"0E]#0HM"0D)"0E]#0HM"0D)"7T at 96QS
M96EF("@D=&AI<RT^9&]N=$-H96-K1F]R17AI<W1I;F=496UP1FEL92!\?" A
M)'1H:7,M/F9I;&5?97AI<W1S7W1Y<&\S=&5M<%]F:6QE*"1O=71P=70L)&EM
M86=E9FEL92DI('L-"BL)"0D):68@*"1T:&ES+3YD;VYT0VAE8VM&;W)%>&ES
M=&EN9U1E;7!&:6QE('Q\("$D=&AI<RT^9FEL95]E>&ES='-?='EP;S-T96UP
M7V9I;&4H)&]U='!U="P@)&EM86=E9FEL92DI"7L-"B )"0D)"21T:&ES+3YI
M;6%G94UA9VEC:T5X96,H)&EM86=E9FEL92XD9G)A;64L)&]U='!U="PD8V]M
M;6%N9"D[#0H@"0D)"7T-"B )"0D):68@*$!F:6QE7V5X:7-T<R at D;W5T<'5T
&*2D)>PT*
`
end