[TYPO3-core] small CSS changes (t3skin)

Helmut Hummel typo3 at jhpc.de
Mon Mar 10 22:02:27 CET 2008


Hi Patrick,

Patrick Gaumond wrote:
> 
> I haven't tried your patch but I looked at your screenshots available at 
>  http://bugs.typo3.org/view.php?id=7790 .

Well you should do and see the impact the patch does on <h1>, <h2> tags used in 
the backend.

> So from looking at the screenshots I would say +1 

You can give +1 based on reviewing the patch or by tresting it, not by looking 
at screenshots...

> but have to look at 
> behavior for extensions by other people.

Exactly that's the problem. After applying the patch many headlines does not 
look well any more. I tend to say that this should be solved in the extension b 
adding classes to the headline there.

> Great impact screenshots tend to get their patches committed... ;)

I don't think so, unless we allow voting based on looking at screenshots ;)

-- 
lib.salutation = TEXT
lib.salutation.value = Kind regards, Helmut
lib.salutation.lang.de = Viele Grüße, Helmut


More information about the TYPO3-team-core mailing list