[TYPO3-core] RFC: #1364, #5985, #7624: improved version of getUrl (cUrl, CURLOPT_FOLLOWLOCATION, error reporting)

[Michael Stucki]

Hi Masi,

>> Functional test:
>> 
>> - I only tried to update the TER updates using the cURL extension. Still
>>   works well.
>> 
>> +1 from me, so this is now ready to be commited. Hurry up, please! :-)
> 
> Commited

There was another debug line which was not removed from the final version. I
have done so now, see attached patch.

>>> PS: What about the PHP version now? If it's really 5.2 (as announced)
>>> and not 5.1 (as in the current code) I could use error_get_last() to
>>> report even file_get_contents() errors.
>> 
>> Officially 5.2 is the limit, but technically there are (afaik) still no
>> requirements beyond PHP 5.1. I still care about those RH and SuSE systems
>> who still seem to ship with 5.1 instead of something more recent (they
>> call this "enterprise" software).
> 
> I have added this stuff:
> 
> if (function_exists('error_get_last')) {
>    $phpError = error_get_last();
>    $report['error'] = $phpError['type'];
>    $report['message'] = $phpError['message'];
> } else {
>    $report['error'] = -1;
>    $report['message'] = 'Couldn\'t get URL.';
> }
> 
> Though there is little benefit.

I think it is good that way. Remember to remove it once we drop 5.1 support
completely.

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_3346.diff
Type: text/x-diff
Size: 1404 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/50b656e2/attachment.diff