[TYPO3-core] RFC: Resubmission of feature #1585: Logfile by Request URI + configuration of Empty Referer handling + logline hook

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Sun Mar 2 18:25:19 CET 2008


Steffen Kamper schrieb:
> "Martin Kutschker" <martin.kutschker-n0spam at no5pam-blackbox.net> schrieb im 
> Newsbeitrag 
> news:mailman.1.1204476693.11558.typo3-team-core at lists.netfielders.de...
>> Steffen Kamper schrieb:
>>> "Martin Kutschker" <martin.kutschker-n0spam at no5pam-blackbox.net> schrieb 
>>> im Newsbeitrag 
>>> news:mailman.1.1204472123.827.typo3-team-core at lists.netfielders.de...
>>>> class t3lib_div {
>>>>   const SYSLOG_SEVERITY_INFO = 0;
>>>> }
>>>>
>>> this is not bad but has a long call
>>> t3lib_div::SYSLOG_SEVERITY_INFO
>>>
>>> so i would prefer the global constants for it.
>> But you should make it T3LIB_DIV_SYSLOG_SEVERITY_INFO and not simply 
>> TYPO3_SEVERITY_INFO so there's not much to gain.
>>
>> Besides, we should get used to longer names to be ready for 5.0 :-)
> 
> :) I used SYSLOG_SEVERITY_INFO which is imho expressive enough because 
> prefix SYSLOG
> Using T3LIB_DIV is too much for it, maybe we move this some day to a 
> t3lib_log and then we have to rename all constants.

With this argument all kind of "namespaces" are void. Why use t3lib_* if 
we could rename it someday to foolib_* or whatever.

I still don't dig all of the new things that TYPO3 5.0 tries to use, but 
I agrre that we should use the new stuff that PHP offers us. Class 
constants are one of them.

Maybe it is better if you use plain old integers for now, and we can 
discuss later on (T3DD08?) how we should go on for 4.3.

Masi


More information about the TYPO3-team-core mailing list