[TYPO3-core] RFC: Fix (part of) #7589: FULLTEXT keys are not processed correctly

Michael Stucki michael at typo3.org
Sun Mar 2 03:03:08 CET 2008


Attached are the remaining patches to make this feature complete.

As you can notice, this will also take care of extra data such as table
engine and collation of the table. This will be essential for full UTF8
support (which unfortunately did not make it into this version).

So the character set/collation detection is basically done, but has been
disabled by a comment to avoid large numbers of differences during DB
comparision.

How to test these patches:

Just make sure you perform a DB comparison after every patch that has been
applied. Generally nothing should be suggested for change except the table
engine in case it was different (yeah, installations which had been
upgraded from 4.0 to 4.1 did not change the table engine for index_*
although this was suggested by ext_tables.sql)

How to review these patches:
I have done my best to split everything into the most readable form. If you
have any questions, I'll be happy to help you.

As a little bonus I have attached "blobToText.diff" which comes from bug
#6098 but is pretty related with this one. Actually this would allow one to
perform a database conversion to UTF8 with a minimal effort (just uncomment
the above mentioned collation detection and follow the steps described in
#6098).

- michael

Michael Stucki wrote:

> This is a SVN patch request.
> 
> Problem:
> If any table includes FULLTEXT key, that key will not be processed
> correctly. Both EM and instal tool will prompt to add key permanently even
> if key exists.
> 
> Solution:
> No solution yet. This patch is doing some cleanup first. I have already
> written the actual solution, but it would be hard to review it if it were
> mixed with these non-functional changes.
> 
> However, since I've run into trouble last time committing non-functional
> changes, I will first post it here to be sure.
> 
> Branches: TYPO3_4-2
> 
> Bugtracker Reference:
> http://bugs.typo3.org/view.php?id=7589
> 
> - michael

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: blobToText.diff
Type: text/x-diff
Size: 6427 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/cfc20c94/attachment-0007.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step1_bug_7589_pre.diff
Type: text/x-diff
Size: 7603 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/cfc20c94/attachment-0008.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step2_fulltext_support.diff
Type: text/x-diff
Size: 2996 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/cfc20c94/attachment-0009.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step2_fulltext_support_w.diff
Type: text/x-diff
Size: 2115 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/cfc20c94/attachment-0010.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step3_findExtraDiff.diff
Type: text/x-diff
Size: 4147 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/cfc20c94/attachment-0011.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step4_charset_support.diff
Type: text/x-diff
Size: 4295 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/cfc20c94/attachment-0012.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step5_todo_cleanup.diff
Type: text/x-diff
Size: 1872 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080302/cfc20c94/attachment-0013.diff 


More information about the TYPO3-team-core mailing list