[TYPO3-core] RFC: Fix bug #7397: Proxy servers replace REMOTE_ADDR with their own IP
Michael Stucki
michael at typo3.org
Sat Mar 1 23:01:54 CET 2008
Hi Martin,
>> Most important: Please _always_ check your patches before committing
>> them! Just run "svn diff" and you would see this, for example: Your patch
>> removes a line in config_default.php which should stay there (unless you
>> provide a good reason for it):
>> - 'SC_mod_web_perm_ajax::dispatch' => [...]
>
> Fixed.
True, however you did again not check your patch. Hunks 3, 4, 5 and 6 of
class.t3lib_div.php revert changes that were made before! Must be fixed.
Rest is fine, +1 again.
As Ingo already mentioned, this is considered to be a bug. However the
changes might have some impact which is why this needs to be tested.
I think that unless anyone objects now, this change should be committed so
it can be tested in beta3.
- michael
--
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
More information about the TYPO3-team-core
mailing list