[TYPO3-core] FYI: small cleanup in tslib

[Dmitry Dulepov [typo3]]

Hi!

Oliver Hader wrote:
> Thanks for the changes! But... ;)
> 
> + /* @var $INTiS_cObj tslib_cObj */
> 
> Shouldn't that be "@var <datatype> <optional description>"? [1]

No. Then it would be "/** @var" :) "/* @var" is for IDEs like PDT or Zend Studio to make type hints inside code. It works like this:

$var = t3lib_div::makeInstance('class');
/* @var $var class */
$var->     <<<<< and here you get popup with list of attributes/functions.

phpDoc's syntax of @var also can be used but it makes no sense inside function. It works only for class members, not inline.

> $GLOBALS['TSFE']->config[$ext.'incScript'][$substKey] = array(
> -                    'file'=>$incFile,
> +                    'file' => $conf['includeLibs'],
> 
> This means that it was also wrong in earlier TYYPO3 releases (4.1, 4.0, 
> ...)? I'm not sure if the 'file' key is required there at all. It was 
> only used for the objects PHP_SCRIPT/~_EXT/~_INT to include one single 
> file. And 'includeLibs' is a list of files.

Yes, it is not required but (as you pointed below) still used. I think it is good to have it.

> The only occurrence for USER_INT/COA_INT of the 'file' key is in 
> tslib_fe::INTincScript_process() for logging in time track:
> $GLOBALS['TT']->push('Include '.$INTiS_config[$INTiS_key]['file'],'');

-- 
Dmitry Dulepov
TYPO3 core team
Web: http://typo3bloke.net/
Skype: callto:liels_bugs
"Nothing is impossible. There are only limits to our knowledge"