[TYPO3-core] RFC: #2302: substitute all strtoupper/strtolower with the t3lib_div-method

[Martin Kutschker]

Dmitry Dulepov [typo3] schrieb:
> Hi!
> 
> Steffen Kamper wrote:
>> remember the turkish problem - if you apply strtoupper or strtolower
>> to any string containing an "i" method will fail
>>
>> So intention was to use it consequent on any place
> 
> This has nothing to do with consistency. You just replaced all
> occurencies without thinking if it is necessary or not.
> 
> If strtolower fails when you check for 'true', you already know it is
> not 'true' or 'tRuE' string! There is no need for t3lib_div method in
> this case.

You wouldn't need it anyway for 'true' as the only letter that behaves
different in a local is the letter i which has two variants in Turkish
(one with a dor and one without).

Masi