[TYPO3-core] RFC #8497 User Admin > Compare User Settings Inconsistencies

[Francois Suter]

Hi Michiel,

> Problem:
> - checkbox list is too long
> - the save button in the docheader should not be a sav button but an 
> update button
> - the save button is too far away from the checkboxes, breaks the flow 
> in this case

Nice patch. One question however: if more elements are added to the list 
of otpions, we may end up with 4 or more columns. This is maybe 
unlikely, but how about using something like ceil($options / 3) rather 
than the hard-coded value of 6? Then of course, the 3 is hard-code too 
:-) It still seems better that way.

Reviewing done as part of the Swiss TUG meeting. Greetings from Lausanne :-)

Apart from that +1 on reading and testing.

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch