[TYPO3-core] RFC #8591: Umlauts get broken in shortcut menu while renaming the shortcut

[Tobias Liebig]

This is an SVN patch request.


Type: Code Cleanup


Bugtracker references:
http://bugs.typo3.org/view.php?id=8591


Branches:
4.2, Trunk


Problem:
Posts in Ajax.requests (prototype) are always UTF-8 encoded, but they 
are expected to be encoded like the backend is (iso-8859-1 by default).
This caused special chars to get mixed up (happes eg in shortcut menu 
and in the t3editor)


Solution:
Recode/convert all GET and POST values for every Ajax.Request where the 
content-type charset does not match with the backend charset
this is handled by class.typo3ajax.php to ensure it works correct for 
every ajax-call which uses the new ajax.php


Note:
For the t3editor i introduce an "workaround" for this issue earlier. 
There i tried to to solve it on client side (javascript) by replacing 
"encodeURIcomponent" by "escape". Unfortunately "escape" does not encode 
"+" correct. see #8591. This workaround should be removed. See my next post.


Note II:
This issue is related for all requests which use 
"ajax.php/class.typo3ajax.php" in the backend.
Most of them do not send any content, but just request some code from 
the server. So they had no problem at all.
Any ajax request, which sends content (e.g. input-values, names) to the 
server, would have the same problem and thus should be tested.


What/Howto test:
shortcut menu: see bugtracker #8591
t3editor: depends on another patch: see #8264 (next post)
any other case which uses ajax.php/class.typo3ajax.php


some testcases:
Use default charset (iso-8859-1) for the backend (by not setting 
forceCharset)
Use UTF-8 for the backend (set forceCharset to utf-8)
Use any other charset
Use special chars (ä ü ö) and a plus sign "+" in the shortcut title
...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_ajax_20080606_8591.diff
Type: text/x-diff
Size: 1236 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080606/f5ce6ffe/attachment.diff