[TYPO3-core] RFC: #8543: Enhance page modul

[Ingo Renner]

Steffen Kamper wrote:

>> * do not add an empty line at the end of the file (chunk 2)
>>
> i ever wonder how this happens because i didn't add a line there.

most likely you editor by using wrong line endings/new lines

>> * no php4 style class member declarations! (chunk 1)
>>
> you mean using "protected" ? Then a cleanup of the other vars should be done 
> in next step.

yepp

>> * do you really need a new css class? (normal-element) I guess it is
>> possible to identify these divs by using css selectors already
> 
> i tried that before, but it's not easy to adress that div, so the class name 
> does that job easy

ok

>> * when using a css class, you also don't need to define the column width
>> in the element itself, put it in the css class
>>
> css doesn't allow dynamic change, that's the reason to use width inline

what's dynamic here?


>> chunk 3:
>> * I wouldn't recommend to move the Help icon to the right of the table
>> as it'll get out of sight then and make the page wider
> 
> i agree that it's outside, but i did this to be consistent, help is added 
> always to the right

consitent to what? I can't remember any place where it is on the right...

>> chunk 7:
>> * why spreading the new and edit icons to the left and right? To be
>> consistent with the CEs (and most likely all other places) just move
>> both of them to the left.
>>
> the idea was for clarity reason, but i can move them back to the left, using 
> "gaps" to group icons

yes, please do so

>> chunk ?
>> * the new info lay is great! Just make it as wide as the CE and let it
>> show up below the row with the edit icons.
> 
> for simplicity i used the csh-class that exists. Problem could be if there 
> are more infos shown than would fit in CE div.

then add auto scrollbars maybe


> thx for intensive review. I will take it into account after clearify of some 
> points.

have fun
Ingo


-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2