[TYPO3-core] RFC: #8543: Enhance page modul

[Ingo Renner]

Hi Steffen,

here's my review:

As discussed with you before, I don't see this yellow-pinkish color fit 
into the current color scheme of the BE yet. See the attached image for 
a proposal.


t3lib_recordlist
====================

* looks like the function in chunk 1 also needs a cleanup - quite hard 
to read that code
* do not add an empty line at the end of the file (chunk 2)


class.tx_cms_layout.php
===========================

* no php4 style class member declarations! (chunk 1)

chunk 2:
* do you really need a new css class? (normal-element) I guess it is 
possible to identify these divs by using css selectors already
* when using a css class, you also don't need to define the column width 
in the element itself, put it in the css class

chunk 3:
* I wouldn't recommend to move the Help icon to the right of the table 
as it'll get out of sight then and make the page wider
* you're removing the default width of the table (480px), I'm not sure 
yet whether this could cause some trouble

chunk 4 and 6:
* again: I wouldn't move the help to the right

chunk 7:
* why spreading the new and edit icons to the left and right? To be 
consistent with the CEs (and most likely all other places) just move 
both of them to the left.

chunk ?
* the new info lay is great! Just make it as wide as the CE and let it 
show up below the row with the edit icons.

* what about this?:
-					$this->infoGif($infoArr).
+					#$this->infoGif($infoArr).


db_layout.php
===============
* chunk 2 has leading spaces instead of tabs


ext-cms-layout-db-layout-php.css
===================================
* insert an empty line after each }
* use lowercase hex values


template.php
==============
* do not put $linkParams at the beginning of the anchor tag



that's it for now =)
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: colors.png
Type: image/png
Size: 23316 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080602/9857a990/attachment-0001.png