[TYPO3-core] RFC #8510: Hardcoded labels in typo3/show_item.php

[Christopher]

Hi Ralf,

"Ralf Hettinger" schrieb im Newsbeitrag 
news:mailman.1.1212390817.16605.typo3-team-core at lists.netfielders.de...
> Hi Christopher,
>
>> Solution:
>> I made them translateable with llxml-translate. :-)
>
> I think to remember that following the CGL you shouldn't reference to 
> global
> vars by global $LANG, but rather refer to $GLOBALS['LANG'] instead.

Yes, I changed it in version 2 of the patch (see attachment).
Correct now?

Christopher 


begin 666 8510_v2_show_item.diff
M+2TM('1Y<&\S+W-H;W=?:71E;2UO<FEG+G!H< DR,# X+3 V+3 R(#$R.C4S
M.C0S+C P,# P,# P," K,#(P, HK*RL@='EP;S,O<VAO=U]I=&5M+G!H< DR
M,# X+3 V+3 R(#$R.C4S.C0T+C P,# P,# P," K,#(P, I 0" M,S$R+#$P
M("LS,3(L,3 @0$ *( D))'1H:7,M/F-O;G1E;G0N/2 D=&AI<RT^9&]C+3YS
M96-T:6]N*"<G+" D8V]D92D["B *( D)"2\O(%)E9F5R96YC97,Z"BT)"21T
M:&ES+3YC;VYT96YT+CT@)'1H:7,M/F1O8RT^<V5C=&EO;B at G4F5F97)E;F-E
M<R!T;R!T:&ES(&ET96TZ)RPD=&AI<RT^;6%K95)E9B at D=&AI<RT^=&%B;&4L
M)'1H:7,M/G)O=ULG=6ED)UTI*3L**PD))'1H:7,M/F-O;G1E;G0N/2 D=&AI
M<RT^9&]C+3YS96-T:6]N*"1'3$]"04Q36R=,04Y')UTM/G-,*"=,3$PZ15A4
M.FQA;F<O;&]C86QL86YG7V-O<F4N<&AP.G-H;W=?:71E;2YP:' N<F5F97)E
M;F-E<U1O5&AI<TET96TG*2PD=&AI<RT^;6%K95)E9B at D=&AI<RT^=&%B;&4L
M)'1H:7,M/G)O=ULG=6ED)UTI*3L*( H@"0D)+R\@4F5F97)E;F-E<SH*+0D)
M)'1H:7,M/F-O;G1E;G0N/2 D=&AI<RT^9&]C+3YS96-T:6]N*"=2969E<F5N
M8V5S(&9R;VT@=&AI<R!I=&5M.B<L)'1H:7,M/FUA:V52969&<F]M*"1T:&ES
M+3YT86)L92PD=&AI<RT^<F]W6R=U:60G72DI.PHK"0DD=&AI<RT^8V]N=&5N
M="X]("1T:&ES+3YD;V,M/G-E8W1I;VXH)$=,3T)!3%-;)TQ!3D<G72T^<TPH
M)TQ,3#I%6%0Z;&%N9R]L;V-A;&QA;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H
M<"YR969E<F5N8V5S1G)O;51H:7-)=&5M)RDL)'1H:7,M/FUA:V52969&<F]M
M*"1T:&ES+3YT86)L92PD=&AI<RT^<F]W6R=U:60G72DI.PH@"7T*( H@"2\J
M*@I 0" M,S4V+#<@*S,U-BPW($! "B )"21C;V1E+CTG("9N8G-P.R9N8G-P
M.SQB/B<N)$Q!3D<M/G-,*"=,3$PZ15A4.FQA;F<O;&]C86QL86YG7V-O<F4N
M<&AP.G-H;W=?:71E;2YP:' N9FEL97-I>F4G*2XG.CPO8CX@)RYT,VQI8E]D
M:78Z.F9O<FUA=%-I>F4H0&9I;&5S:7IE*"1T:&ES+3YF:6QE*2DN)SQB<B O
M/@H@"0D))SL*( D):68@*&ES7V%R<F%Y*"1I;6=);F9O*2D)>PHM"0D))&-O
M9&4N/2 G/&(^)RXD3$%.1RT^<TPH)TQ,3#I%6%0Z;&%N9R]L;V-A;&QA;F=?
M8V]R92YP:' Z<VAO=U]I=&5M+G!H<"YD:6UE;G-I;VYS)RDN)SH\+V(^("<N
M)&EM9TEN9F];,%TN)W at G+B1I;6=);F9O6S%=+B<@<&EX96QS)SL**PD)"21C
M;V1E+CT@)SQB/B<N)$=,3T)!3%-;)TQ!3D<G72T^<TPH)TQ,3#I%6%0Z;&%N
M9R]L;V-A;&QA;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H<"YD:6UE;G-I;VYS
M)RDN)SH\+V(^("<N)&EM9TEN9F];,%TN)W at G+B1I;6=);F9O6S%=+B<@)RXD
M1TQ/0D%,4ULG3$%.1R==+3YS3"@G3$Q,.D585#IL86YG+VQO8V%L;&%N9U]C
M;W)E+G!H<#IS:&]W7VET96TN<&AP+G!I>&5L<R<I.PH@"0E]"B )"21T:&ES
M+3YC;VYT96YT+CTD=&AI<RT^9&]C+3YS96-T:6]N*"<G+"1C;V1E*3L*( D)
M)'1H:7,M/F-O;G1E;G0N/21T:&ES+3YD;V,M/F1I=FED97(H,BD["D! ("TT
M,3(L-R K-#$R+#<@0$ *( H@"0D)"0D))&-O9&4N/2<*( D)"0D)"0D)("TM
M+2TM+2T\8G(O/@HM"0D)"0D)"0D@)RYC;W5N="@D="DN)R!F:6QE<R<["BL)
M"0D)"0D)"2 G+F-O=6YT*"1T*2XG("<N)$=,3T)!3%-;)TQ!3D<G72T^<TPH
M)TQ,3#I%6%0Z;&%N9R]L;V-A;&QA;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H
M<"YF:6QE<R<I.PH@"B )"0D)"0DD8V]D92 ]("<*( D)"0D)"0D\<W!A;B!C
M;&%S<STB;F]B<B(^)RXD8V]D92XG"D! ("TT,C(L-R K-#(R+#<@0$ *( D)
M"0D))'1H:7,M/F-O;G1E;G0N/2 D=&AI<RT^9&]C+3YS96-T:6]N*"<G+"1C
M;V1E*3L*( D)"0E]"B )"0E](&5L<V5I9B H)$=,3T)!3%-;)U194$\S7T-/
M3D9?5D%24R==6R="12==6R=D:7-A8FQE7V5X96-?9G5N8W1I;VXG72D@>PHM
M"0D)"21T:&ES+3YC;VYT96YT+CT@)'1H:7,M/F1O8RT^<V5C=&EO;B at G)RPG
M4V]R<GDL(%194$\S7T-/3D9?5D%24UM"15U;9&ES86)L95]E>&5C7V9U;F-T
M:6]N72!W87,@<V5T+"!S;R!C86YN;W0 at 9&ES<&QA>2!C;VYT96YT(&]F(&%R
M8VAI=F4 at 9FEL92XG*3L**PD)"0DD=&AI<RT^8V]N=&5N="X]("1T:&ES+3YD
M;V,M/G-E8W1I;VXH)R<L)$=,3T)!3%-;)TQ!3D<G72T^<TPH)TQ,3#I%6%0Z
M;&%N9R]L;V-A;&QA;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H<"YC86YN;W1$
M:7-P;&%Y07)C:&EV92<I*3L*( D)"7T*( H@"0D)"2\O($9O;G0 at 9FEL97,Z
M"D! ("TT-# L-R K-#0P+#<@0$ *( H@"B )"0DO+R!2969E<F5N8V5S. at HM
M"0DD=&AI<RT^8V]N=&5N="X]("1T:&ES+3YD;V,M/G-E8W1I;VXH)U)E9F5R
M96YC97,@=&\@=&AI<R!I=&5M.B<L)'1H:7,M/FUA:V52968H)U]&24Q%)RPD
M=&AI<RT^9FEL92DI.PHK"0DD=&AI<RT^8V]N=&5N="X]("1T:&ES+3YD;V,M
M/G-E8W1I;VXH)$=,3T)!3%-;)TQ!3D<G72T^<TPH)TQ,3#I%6%0Z;&%N9R]L
M;V-A;&QA;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H<"YR969E<F5N8V5S5&]4
M:&ES271E;2<I+"1T:&ES+3YM86ME4F5F*"=?1DE,12<L)'1H:7,M/F9I;&4I
M*3L*( E]"B *( DO*BH*0$ @+30V,BPV("LT-C(L-R! 0 H@"2 J($!R971U
M<FX)<W1R:6YG"0E(5$U,"B )("HO"B )9G5N8W1I;VX@;6%K95)E9B at D=&%B
M;&4L)')E9BD)>PHK"0EG;&]B86P@)$Q!3D<["B *( D):68@*"1T86)L93T]
M/2=?1DE,12<I"7L*( D)"0DO+R!&:7)S="P at 9FET('!A=&@@=&\@;6%T8V@@
M=VAA="!I<R!S=&]R960@:6X@=&AE(')E9FEN9&5X. at I 0" M-#DT+#$R("LT
M.34L,3(@0$ *( D))&EN9F]$871A(#T at 87)R87DH*3L*( D):68@*&-O=6YT
M*"1R;W=S*2D)>PH@"0D))&EN9F]$871A6UT@/2 G/'1R(&-L87-S/2)B9T-O
M;&]R-2!T86)L96AE861E<B(^)R N"BT)"0D)"2<\=&0^5&%B;&4Z/"]T9#XG
M("X*+0D)"0D))SQT9#Y5:60Z/"]T9#XG("X*+0D)"0D))SQT9#Y&:65L9#H\
M+W1D/B<N"BT)"0D)"2<\=&0^1FQE>'!O:6YT97(Z/"]T9#XG+ at HM"0D)"0DG
M/'1D/E-O9G1R968 at 2V5Y.CPO=&0^)RX*+0D)"0D))SQT9#Y3;W)T:6YG.CPO
M=&0^)RX**PD)"0D))SQT9#XG+B1'3$]"04Q36R=,04Y')UTM/G-,*"=,3$PZ
M15A4.FQA;F<O;&]C86QL86YG7V-O<F4N<&AP.G-H;W=?:71E;2YP:' N=&%B
M;&4G*2XG/"]T9#XG("X**PD)"0D))SQT9#XG+B1'3$]"04Q36R=,04Y')UTM
M/G-,*"=,3$PZ15A4.FQA;F<O;&]C86QL86YG7V-O<F4N<&AP.G-H;W=?:71E
M;2YP:' N=6ED)RDN)SPO=&0^)R N"BL)"0D)"2<\=&0^)RXD1TQ/0D%,4ULG
M3$%.1R==+3YS3"@G3$Q,.D585#IL86YG+VQO8V%L;&%N9U]C;W)E+G!H<#IS
M:&]W7VET96TN<&AP+F9I96QD)RDN)SPO=&0^)RX**PD)"0D))SQT9#XG+B1'
M3$]"04Q36R=,04Y')UTM/G-,*"=,3$PZ15A4.FQA;F<O;&]C86QL86YG7V-O
M<F4N<&AP.G-H;W=?:71E;2YP:' N9FQE>'!O:6YT97(G*2XG/"]T9#XG+ at HK
M"0D)"0DG/'1D/B<N)$=,3T)!3%-;)TQ!3D<G72T^<TPH)TQ,3#I%6%0Z;&%N
M9R]L;V-A;&QA;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H<"YS;V9T<F5F2V5Y
M)RDN)SPO=&0^)RX**PD)"0D))SQT9#XG+B1'3$]"04Q36R=,04Y')UTM/G-,
M*"=,3$PZ15A4.FQA;F<O;&]C86QL86YG7V-O<F4N<&AP.G-H;W=?:71E;2YP
M:' N<V]R=&EN9R<I+B<\+W1D/B<N"B )"0D)"2<\+W1R/B<["B )"7T*( D)
M9F]R96%C:"@D<F]W<R!A<R D<F]W*0E["D! ("TU,C0L-B K-3(U+#<@0$ *
M( D@*B! <F5T=7)N"7-T<FEN9PD)2%1-3 H@"2 J+PH@"69U;F-T:6]N(&UA
M:V52969&<F]M*"1T86)L92PD<F5F*0E["BL)"6=L;V)A;" D3$%.1SL*( H@
M"0D)+R\@3&]O:R!U<"!T:&4@<&%T:#H*( D))')O=W,@/2 D1TQ/0D%,4ULG
M5%E03S-?1$(G72T^97AE8U]314Q%0U1G9712;W=S* I 0" M-3,W+#$S("LU
M,SDL,3, at 0$ *( D))&EN9F]$871A(#T at 87)R87DH*3L*( D):68@*&-O=6YT
M*"1R;W=S*2D)>PH@"0D))&EN9F]$871A6UT@/2 G/'1R(&-L87-S/2)B9T-O
M;&]R-2!T86)L96AE861E<B(^)R N"BT)"0D)"2<\=&0^1FEE;&0Z/"]T9#XG
M+ at HM"0D)"0DG/'1D/D9L97AP;VEN=&5R.CPO=&0^)RX*+0D)"0D))SQT9#Y3
M;V9T<F5F($ME>3H\+W1D/B<N"BT)"0D)"2<\=&0^4V]R=&EN9SH\+W1D/B<N
M"BT)"0D)"2<\=&0^4F5F(%1A8FQE.CPO=&0^)R N"BT)"0D)"2<\=&0^4F5F
M(%5I9#H\+W1D/B<@+ at HM"0D)"0DG/'1D/E)E9B!3=')I;F<Z/"]T9#XG("X*
M*PD)"0D))SQT9#XG+B1'3$]"04Q36R=,04Y')UTM/G-,*"=,3$PZ15A4.FQA
M;F<O;&]C86QL86YG7V-O<F4N<&AP.G-H;W=?:71E;2YP:' N9FEE;&0G*2XG
M/"]T9#XG+ at HK"0D)"0DG/'1D/B<N)$=,3T)!3%-;)TQ!3D<G72T^<TPH)TQ,
M3#I%6%0Z;&%N9R]L;V-A;&QA;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H<"YF
M;&5X<&]I;G1E<B<I+B<\+W1D/B<N"BL)"0D)"2<\=&0^)RXD1TQ/0D%,4ULG
M3$%.1R==+3YS3"@G3$Q,.D585#IL86YG+VQO8V%L;&%N9U]C;W)E+G!H<#IS
M:&]W7VET96TN<&AP+G-O9G1R969+97DG*2XG/"]T9#XG+ at HK"0D)"0DG/'1D
M/B<N)$=,3T)!3%-;)TQ!3D<G72T^<TPH)TQ,3#I%6%0Z;&%N9R]L;V-A;&QA
M;F=?8V]R92YP:' Z<VAO=U]I=&5M+G!H<"YS;W)T:6YG)RDN)SPO=&0^)RX*
M*PD)"0D))SQT9#XG+B1'3$]"04Q36R=,04Y')UTM/G-,*"=,3$PZ15A4.FQA
M;F<O;&]C86QL86YG7V-O<F4N<&AP.G-H;W=?:71E;2YP:' N<F5F5&%B;&4G
M*2XG/"]T9#XG("X**PD)"0D))SQT9#XG+B1'3$]"04Q36R=,04Y')UTM/G-,
M*"=,3$PZ15A4.FQA;F<O;&]C86QL86YG7V-O<F4N<&AP.G-H;W=?:71E;2YP
M:' N<F5F56ED)RDN)SPO=&0^)R N"BL)"0D)"2<\=&0^)RXD1TQ/0D%,4ULG
M3$%.1R==+3YS3"@G3$Q,.D585#IL86YG+VQO8V%L;&%N9U]C;W)E+G!H<#IS
M:&]W7VET96TN<&AP+G)E9E-T<FEN9R<I+B<\+W1D/B<@+ at H@"0D)"0DG/"]T
F<CXG.PH@"0E]"B )"69O<F5A8V at H)')O=W, at 87,@)')O=RD)>PH`
`
end