[TYPO3-core] RFC: #8644: Usersettings with fullHelptextMode looks weird

Steffen Kamper info at sk-typo3.de
Fri Jul 25 16:47:32 CEST 2008


Benjamin Mack schrieb:
> Hey Steffen,
> 
> what's the status here?
> 
> Benjamin Mack wrote:
>> Hey Steffen,
>>
>> very nice patch.
>>
>> Some remarks...
>>
>> Hunk #2:
>>
>> +$this->doc->tableLayout['defRowEven'] = array (
>> +    'defCol' => array (
>> +        '<td valign="top" colspan="3">','</td>'
>> +    ),
>> +);
>>
>> we can unify line 2-4 in one line (just like in hunk #1)
>>
>> Basically in all places where you have
>>   t3lib_BEfunc::cshItem('_MOD_user_setup', 'simuser', $BACK_PATH,'|');
>> you can remove the last parameter, as this wrap is empty by default 
>> anyway.
>>
>> Could you clean them up? I will now give the thing a test-run.
>>
> 

Hi Benni,

here is a modified patch taking your remarks into account.

vg Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: usersettings_help2.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080725/af6a256a/attachment-0001.txt 


More information about the TYPO3-team-core mailing list