[TYPO3-core] RFC #8361: Stage change notification emails not send when publishing from Live workspace

[Andreas Wolf]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Benni,

Benjamin Mack schrieb:
> Hey Andreas,
> 
> +1 after reading. One question I have though: Should the check to see if 
> the current workspace can be used, be kept as an additional check. 
I don't think so, because the patch only changes behaviour when
publishing from live workspace. If you publish from the draft workspace,
there is really no change because checkWorkspaceCurrent() and
checkWorkspace() with the current workspace's id do exactly the same thing.

> Possible:
> * Check access of current workspace
> * Check workspace of the record
So this would just mean to check if the WS id is 0 and if yes, do the
calls I introduced, otherwise still do checkWorkspaceCurrent().
Basically I see no change here, as stated above.

> If not, you have my +1 after reading. Is this is a 
> "has-to-be-approved-by-Kasper" issue? If so, you probably need to send 
> an email to Kasper with the final patch to get his blessings.
I don't really know about that, but as this seems to be a minor issue to
me (only affects notifications and no really critical functionality), I
would say it should be commitable without Kaspers approval. But if you
like, I'll ask him to check the patch.

> greetings from your neighbour!
Greets to you, too.

Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIVAwUBSImZ+gJFrtzcYmY6AQgLTw/+KHEzH8sUUSuwYVI1FOWk0vm+j1mY7IZR
pnZepHt/YT3tUwOh45y8x/kYPdpOSeRpsj/ukOyGlwcmZnSDmgcU9SRk0JYv+Nh1
4VKoI/vxnyoJmafSEXmvFt+FDGOfKREhXLYUrzGB/WOMykDoF25wvNKUDCqg2pT3
xjE80H9ieM4lMIv2HhaefB/HifY/ytaE5a4zOJxVxrPRk3Rba4w7SQeNAXBzDW+q
ejxnMAFxt/k2NVcA8IW6teYbiUbJgWm/8VueKHRgHQiFhHGBW1BeEoBmsSxFMR3p
e9kUxFPyiqjSC75Z0gBOZHa81Gu9IFHrCDsdHjJvDNXZ2mgLZHl/hSi/9rpGjMLc
IxY2T33KH+KV9/jcw8LaKi6Ft2kIJI+qeVQl0DqSnunt4zQdRyRUd+nuN12D2P4P
VnXDxus9FuO2IABxM9sWiwONlOvCT6sV/tnYUCpnYbRZMxb0NmT4HrbruKFq7Fb1
bHnc7gMVsLL/GXZMI9JskLdHDpQZT/l5ECoy2hvsbZjL/ld0Xgqnix9V7ej1U5Y7
5jJCia+F6rMxpeNuYws0/JwA2X2ZV+kSsThUTy/rpFo0L3SbOS9znVhXCJve8fQc
03PYIFdsyK2UCI0fi13SYWTm+CTtt7IzSr1MwWa2Hw+pGk12kQUIL7gd3GK55vZW
MCRu3NsjJ1c=
=P/w/
-----END PGP SIGNATURE-----