[TYPO3-core] RFC #8990: Labels 'TEMP' and 'RECYCLER' are hardcoded

[Oliver Klee]

Hi Stefano,

well done! +1 with the changes Bernhard suggested and the followings 
nits changed:

>  		if ($title=='_recycler_')	{
>  			$icon = 'gfx/i/recycler.gif';
> -			$title='<b>RECYCLER</b>';
> +			$title='<b>' . $GLOBALS['LANG']->getLL('recycler', true) . '</b>';

While you're changing this line, I propose to change the <b> to the 
semantic <strong>. (That's your decision.)

>  		}
> -		$icon = $theFile['writable'] ? 'gfx/i/_icon_'.$webpath.'folders_ro.gif' : $icon;
> +		$icon = $theFile['writable'] ? 'gfx/i/_icon_' . $webpath . 'folders_ro.gif' : $icon;
>  
> -		return Array($title,$icon,$path);
> +		return Array($title, $icon, $path);

Array -> array

> Index: typo3/sysext/lang/locallang_mod_file_list.xml
> ===================================================================
> --- typo3/sysext/lang/locallang_mod_file_list.xml	(revision 3886)
> +++ typo3/sysext/lang/locallang_mod_file_list.xml	(working copy)
> @@ -21,6 +21,8 @@
>  			<label index="c_rw">RW</label>
>  			<label index="c__REF_">Ref</label>			
>  			<label index="files">files</label>
> +			<label index="temp">TEMPORARY FILES</label>
> +			<label index="recycler">RECYCLER</label>	

I find this all-capitals style not very nice-looking. What about using 
the opportunity and changing this to "Temporary files" and "Recycler"? 
(That's also a matter of taste and your decision.)


Oli