[TYPO3-core] RFC #8985: Enable USER object to become USER_INT on the fly

[Ingo Renner]

Dmitry Dulepov [typo3] wrote:

Hi

> Ingo Renner wrote:
>> 9, 18: there's IMO no need to add @var for primitive types, should be 
>> used only for objects
> 
> Done but left comments as /** style (for Zend Studio hints on hover).

sure

>> 11: name the variable $doConvertToUserInt or $convertToUserInt - 
>> always use lowerCamlCase for variables
> 
> Changed to $doConvertToUserInt. Having $convertToUserInt because 
> $this->convertToUserInt is ambigous (is it variable or function address?)
> 
>> 27, 34: add a public access designator. What does OT mean? No 
>> abbreviations, please.
> 
> Constants are always public in PHP. Or did you mean @access?

I just mean "public const" - just for consistency, even if they're 
public by default

>> 75: couldn't that call be moved into the else branch? Seems to be the 
>> only place where $tempContent is used...
> 
> Checked, it could not :( There should be a call to userFunc first but 
> result cannot be assigned to $content immediately because it may have to 
> be discarded.


ok, thanks for all the changes. Will try it out later.


Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2