[TYPO3-core] RFC #8566: Unable to match TS condition when variable is not set

Dmitry Dulepov [typo3] dmitry at typo3.org
Mon Jul 14 15:20:05 CEST 2008


Hi!

Martin Kutschker wrote:
> But they user could have used \/ which is valid, but your "fix" denies
> him this possibility. I wouldn't add an extra test, but use @ in the
> test and maybe add a not to the TS error stack for the admin panel.
> 
> Simpel change for readability:
> 
> if (preg_match('|^/.+/$|', $needle))
> 
> Preferred change that allows / and | to be used as regexp "brackets":
> 
> if (preg_match('#^/.+/$|^.+|$#', $needle))

I am ok to this. I like this more than Olly's patch.

Anyone objects to this? I really want this to be comitted.

-- 
Dmitry Dulepov
TYPO3 Core team
More about TYPO3: http://typo3bloke.net/
Subscribe: http://typo3bloke.net/rss.xml


More information about the TYPO3-team-core mailing list