[TYPO3-core] RFC: #8939: Menu sitemap doesn't respect pages field

Peter Niederlag peter at niederlag.de
Sun Jul 13 12:45:55 CEST 2008


Hello,

Dmitry Dulepov [typo3] schrieb:
> Hi!
> 
> Steffen Kamper wrote:
>> Bugtracker references:
>> 
>> http://bugs.typo3.org/view.php?id=8939
>> 
>> Branches: 4.2, trunk
>> 
>> Problem: there is something missing in tt_content.menu.20.2
>> 
>> All other menu types are copied from default and modified, so they
>> have special = list special.value.field = pages

IMO sitemap always shoudl be 'special=directory' not '=list'.

[...]
> Sitemap displays content of the current site, not the whole tree.
> Imagine the following structure:
> 
> Globe |-- Page |-- Site root  <-- root TS template |-- Subpage
> 
> Currently sitemap will display every page starting from "Site root"
> page. Proposed solution will force sitemap to start from the globe
> level because "pages" field will be empty, which is equivalent to
> making SQL query with pid=0. This is not correct. This will break
> site maps in multipage setups.
> 
> Even more, the patch from http://bugs.typo3.org/view.php?id=3705 is
> wrong too. It converts sitemap to "Menu of subpages to these pages",
> which is a wrong thing to do. Sitemap is sitemap, its starting point
> is root of the web site. "Menu of subpages to these pages" has
> starting point and does exactly what #8939 and #3705 do. Both bugs
> should be discarded as wrong.

How about doing it like this:

tt_content.menu.20.2 = HMENU
tt_content.menu.20.2 {
  special.value.data = leveluid:0
  special.value.override.field = pages
}

This should heal your (correct) concerns and should be backwards
compatible (at least with an empty field pages).

"Menu of subpages to these pages" is something else, as it only renders
one(!) level by default. I'd like to keep it as this. This is something
else than a "sitemap".

If we really want to rework the TS of tt_content.menu it should probably
get e "levels" configuration for the user. My suggestion however would
be to just go with the above change.

Greets,
Peter
-- 
Peter Niederlag * Neuer Sandberg 9 * 31535 Neustadt *
Fon (privat): 05036 / 924 100 * Fon (Büro): 05036 / 924 101
Fon (mobil): 0172 / 516 48 55 * Fax 05036 / 924 105
callto:typo3support (skype)
http://www.niekom.de * TYPO3 und EDV Dienstleistungen *


More information about the TYPO3-team-core mailing list