[TYPO3-core] RFC: #7642: Page tree Filter use wrong div for collapse

Jeff Segars jsegars at alumni.rice.edu
Wed Feb 27 16:30:54 CET 2008


Steffen Kamper wrote:
>  because my patch was made some days ago tree.js may report conflict,
> so i made this patch against latest trunk again,
>  new patch is attached.

>  vg  Steffen 

Hey Steffen,
Thanks for your work!  Definitely an improvement but I do have a
couple questions and comments from testing (haven't really looked at
the code yet).

When the filter is collapsed and we're not in a workspace, which is
the default state, the second row being empty really seems to stick
out to me.  I'm not sure what content would go there, but being empty
doesn't seem right either since its probably the most common state.

Can you add outline: none to input#treeFilter?  That will get rid of
the blue border that Safari uses when an input field gets the focus
and will make the 5% of us actually using Safari very happy ;)
Without it, the blue border shows up inside background image that
frames the input field and throws the whole look off.

It might be good to tweak the styling of the the Filter text and the
arrow while we're at it? (Get rid of the white behind the arrow and
push the alignment of the filter down?)  These are of course minor
nitpicks and could wait for a future patch too.

Thanks,
Jeff




More information about the TYPO3-team-core mailing list