[TYPO3-core] FYI: Committed lots of non-functional changes (to comply with old patch)

[Michael Stucki]

And promptly it hit a problem! :-(

Oliver discovered that the Install Tool wants to change all fields
containing "DEFAULT" properties:
http://bugs.typo3.org/view.php?id=7683

Thinking this is a safe change, I had changed the case type of all SQL
statements including "default '...'" => DEFAULT '...'.

However, it appears like TYPO3 depends on "DEFAULT" being lower-case. So I
have reverted this part of the change, and everything runs fine again.

Sorry for the trouble!

- michael

Michael Stucki wrote:

> These changes are needed because I have worked on the DB parser to allow
> detection and conversion of database types and Fulltext keys.
> 
> (By the way, Dmitrys fulltext-patch is useless if the table type is InnoDB
> and you try to add a fulltext key. It won't work unless the table type is
> MyISAM, so it is necessary to detect and perform such changes.)
> 
> However, don't worry: All changes so far do not touch any functionality, I
> will send that all later...
> 
> You find the changesets attached and online:
> 
> http://code.typo3.org/v4/changeset/3290
> * Rename t3lib_install::getFieldDefinitions_sqlContent() to
>   t3lib_install::getFieldDefinitions_fileContent() and provide a wrapper
>   for backwards compatibility
> 
> http://code.typo3.org/v4/changeset/3294
> * Lots of white-space fixes (to comply with old patch)
> 
> http://code.typo3.org/v4/changeset/3297
> * Fix typo: SQL query was not upper-case
> 
> http://code.typo3.org/v4/changeset/3301
> * Condition rewrite, see check_3301_w.diff for clarification
> 
> http://code.typo3.org/v4/changeset/3295
> http://code.typo3.org/v4/changeset/3296
> http://code.typo3.org/v4/changeset/3298
> http://code.typo3.org/v4/changeset/3299
> http://code.typo3.org/v4/changeset/3300
> http://code.typo3.org/v4/changeset/3302
> 
> * Lots of non-functional changes (to comply with old patch)
> 
> - michael

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rev3301_post1.diff
Type: text/x-diff
Size: 624 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080227/19e70a48/attachment.diff