[TYPO3-core] RFC: Bug #7634: Tabs disappear when BE-editing a record that contains IRRE

Oliver Klee typo3-german-02 at oliverklee.de
Sat Feb 23 18:41:31 CET 2008


Hi Olly,

+1 after reading and testing.

I found some minor style nits; feel free to fix those which you find valid.

+				// Get dividers2tabs setting from TCA of the current table:

Get -> Gets (the third person is preferred for comments)

-					$item.= 
$this->getDynTabMenu($tabParts,'TCEFORMS:flexform:'.$PA['itemFormElName'].$PA['_lang']);
+					$item.= $this->getDynTabMenu($tabParts, 
'TCEFORMS:flexform:'.$PA['itemFormElName'].$PA['_lang'], $table);

Please add a space before .= .

+	 * @param	string		Table to get the tab menu for

Table -> name of the table
Please add ", must not be empty"

+			return $GLOBALS['TBE_TEMPLATE']->getDynTabMenu($parts, $idString, 0, 
FALSE, 50, 1, FALSE, 1, $GLOBALS[$table]['ctrl']

FALSE -> false

Regards,


Oliver


More information about the TYPO3-team-core mailing list