[TYPO3-core] RFC: Feature Request 6037: Performance tunning in t3lib_div by removing elderly PHP functions

Oliver Hader oh at inpublica.de
Fri Feb 22 22:36:33 CET 2008


Hi Michael,

Michael Stucki schrieb:
> see attached patch - was this a typo, or intention? Well, it won't break
> anything, but it's confusing...

-		return (strpos('>,'.$list.',', ','.$item.',') ? true : false);
+		return (strpos(','.$list.',', ','.$item.',') ? true : false);

Intention, but I agree that it is confusing.
The '>,' was added that a positive match would return "1" as integer. If 
the first item in a list would match the position "0" would be returned. 
That was the reason.

If the '>' gets removed, the correct check has to be
strpos(','.$list.',', ','.$item.',')!==false ? true : false

olly
-- 
Oliver Hader
http://inpublica.de/


More information about the TYPO3-team-core mailing list