[TYPO3-core] RFC: #7307 - Open Documents Fixes - Part 1

[Steffen Kamper]

Hi Benni,

"Benjamin Mack" <mack at xnos.org> schrieb im Newsbeitrag 
news:mailman.2470.1203629628.5943.typo3-team-core at lists.netfielders.de...
> Hey guys,
>
> this is a SVN patch request.
>
> BT reference: http://bugs.typo3.org/view.php?id=7307
>
> Branches: 4.2
>
> Problem & Solution:
> 1. The new opendocs toolbar item did not work for quite some time as
> functionality was accidentally removed from alt_doc.php. So I
> reimplemented this feature and the menu works again.
> 2. I also implemented a simple access check so you can disable the
> toolbarItem through UserTSconfig (has to be documented! I will not
> forget that).
>
>   backendToolbarItem.tx_opendocs.disabled = 1
>
> 3. Additionally we wanted to show the number of opened documents in the
> toolbar, so I used the getUpdateSignal() in t3lib_BEfunc and rewrote it.
> Before there was only one function getSetUpdateSignal() which I did not
> like because it was used to get and to set the updatesignal, whether
> there was a parameter or not. This is not good code IMHO so I split it
> in two parts by still keeping backwards compatibility with the old
> function. This function was used to add JScode at the bottom of a page
> and was hardcoded to only update the pagetree if an update was needed. I
> implemented a hook so it is possible for extensions (like tx_opendocs)
> to use this updater as well. I actually use this to update the number of
> opened documents.
>
+1 for this, i see many usecases for this hook.

> 4. I also did some minor fixes to the code.
>
> So, this brings back the full functionality to the tx_opendocs finally.
> There are still things to be done before the final release, but I'd like
> to get your guys' opinion of the code before beta2 (and before I commit
> this :)).
>

The menu is updated proper and the number is displayed.
What doesn't work for me is clicking a menu item, nothing happens. The link 
code should oben the edit of the document, but still nothing, no js error.

One general question:
If i open a record, it's an open document and it's counted.
If i close the record with the close button, the document is still an open 
document? Count doesn't change but it's correct in the menu with Currently 
edited documents, so i think closing doesn't send the updatesignal.


> These tasks are still open for the opendocs - toolbar:
>
> * Search icon still has to be at the end of the toolbar

it should work like page.headerData with a simple array and an index. Search 
could use 9999 and users are free to add the icon with this index.

> * Styling of the topbar
> * The menu entries should be rendered through recordItems with icon etc.
good idea, i would like to have the icon of the record to see which kind of 
doc it is

> * There should be an option to close the records through the menu

> * If menu is opened and a document is closed, it should be refreshed as
> well (trivial)
>

in general i don't loke open menus, no OS let a menu open. I would close 
this menu after leaving the menu area with mouse.

vg  Steffen