[TYPO3-core] RFC: #7532: Docheaders: Wizard New Content Element (db_new_content_el.php): No docheader

[Oliver Hader]

Hi Patrick,

Patrick Broens schrieb:
> Problem:
> Wizard New Content Element (db_new_content_el.php) has no docheader and 
> is not according to new BE user interface
> 
> Solution:
> Add docheader to wizard
> 
> Branches:
> Trunk, TYPO3_4-2
> 
> BT Reference: http://bugs.typo3.org/view.php?id=7532

Thanks for your patch. I have some small annotations:

+		$this->pageinfo = t3lib_BEfunc::readPageAccess($this->id,$perms_clause);
+		$this->access = is_array($this->pageinfo) ? 1 : 0;

--> please add "protected $pageinfo" as new class variable
--> please adjust formatting: space between function arguments
--> wouldn't "$this->access = is_array(...)" be enough for true/false?

-				// Add a very high clear-gif, 700 px (so that the link to the 
anchor "sel2" shows this part in top for sure...)
-			$this->content.= $this->doc->section('','<img src="clear.gif" 
width="1" height="700" alt="" />',0,1);

--> In the new version the part "2: select position" is at the bottom of 
the screeen which was "fixed" by the part you're removing - having it on 
top again would be better IMO

+	private function getButtons()	{
+		global $LANG, $BACK_PATH;

--> please remove the "global" statement and fix the single $LANG 
occurrence in that function to $GLOBALS['LANG']

Thanks in advance for changing the mentioned things!
When done so: +1 on testing and reading

olly
-- 
Oliver Hader
http://inpublica.de/