[TYPO3-core] FYI: Cleanup (wrong global statement) in new TYPO3AJAX class

[Benjamin Mack]

Hey all,

I'm glad we all have time to talk about issues like that while other
contributers are still awaiting reviews from us for their patches.

I couldn't find anything about the "minimum of 4" or "global statement
is discouraged" in the live (but deprecated) CGL document:
http://typo3.org/documentation/document-library/core-documentation/doc_core_cgl/4.1.0/view/1/3/
so I don't see a strong reason other than the personal feeling about 
code from others.

Anyway, I also couldn't find anything useful in the last hour about 
reverting a commit in SVN as a developer, so I won't react on this 
issue. Please feel free to do a followup FYI on my patch and commit your 
cleanup, I am totally cool with that.

I am actually quite pissed that I've spent any time more than necessary 
here for this EXTREME nitpicking where I just should have left as it is.

greetings,
benni.
-SDG-

Dmitry Dulepov [typo3] wrote:
> Hi!
> 
> Benjamin Mack wrote:
>> 1. removes the TYPO3_GLOBAL_VARS as this one is not needed anymore
>> (was used in a previous version but wasn't removed).
> 
> This is ok :)
> 
>> 2. Adds LANG as this is used twice here, which is multiple usages
>> IMHO and thus makes the code easier to read.
> 
> This is what I did not like (just got rid of some globals in
> tt_news). We require four as absolute minimum to allow "global" but
> we try not to use it at all because it is not immediately clear if
> variable is global or not.
>