[TYPO3-core] RFC: Bug #6239: notifyStageChange() does not send emails, if groups are added to WS members/reviewers

[Andreas Wolf]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Patrick,

Patrick Rodacker schrieb:
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=6239
> 
> Branches:
> TYPO3_4-1 & trunk
> Problem:
> The workspace allows to add backend users and backend groups as members
> and reviewers, but email notification is only functional for added
> backend users not the members (users) of an added backend group.
> 
> Solution:
> Extend the function notifyStageChange_getEmails() to handle not only
> added backend users entries but also backend user groups correctly.
I really like the feature, but I see one problem with the patch: A check
of $users[0] with is_array() should be added in these two lines:

+		if (count($users[0])>0) {
+			if (count($groups[0])>0) {

 * You also initalize the array $groupIds, but don't use it anywhere.
 * These two lines could be merged into one, together with the
is_array()-check:

+               if (!$noTablePrefix) {
+                       if (count($groups[0])>0) {

Apart from that, +1 based on reading.

Cheers,

Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIVAwUBR63N+AJFrtzcYmY6AQguVxAAik2kBlPVEuWRqUUhtwW0TYTUCyiYBANS
KMMpxTFSvhF1awddWtJ2cRXqP1sobKJGvm0dPQbZfLTwI4/swZTKK1j+9ehMAd9L
weTczObqWNqsTLCdccCAlwRRHVSG4YnVIiTKM1GeF+glwZm6JLvgEjcBAel/6Tgw
Tm4P/wIZw2L5RiHNKA6yuhfpFp0LASwj1Au626ZUaZirPGVYdsLIetFVATQ2UKBD
XDIxl9BkVpphQ+gLPy/9n298XNOfonjmpFB9hhrBAOGJu4k/Xonn1xdRTPkpw3NN
ju54KpDXg+/y4j8x9OtMoy3IdgcL3eRBMTbBKxy46f7of+0C2sLey++Huzxt+R/S
5lndFlTbLisJq6FfyaR+Gooj8D2M7lxwPXpe+T7KGdsLNUIEDZP+lU4AdCMzICOM
MZhBFSDnT0XCnQ3F2RYfgARyMEXvRnaEYJ0GYRhXFK9WYqSb7vSeLMsiX5eBD79n
y2kPUx1sZ78pSWDmRW6/W85YU1n65+zDGYfummVsTLPxG8SCZHcoKoIQfbiAA2FB
YGxvrPO1hKuB36tD0b19xm0P0UTA4laHH+TeBCSImQy3B1jKwDK44Zv+xg2rB18w
WGhNZHXK8+I8ZAlU0bAT01N9H6SYmH7viEtTPoOoTUu+Bed8pIpobOeutwm4pSwt
Fg/u4opUKuA=
=kgVI
-----END PGP SIGNATURE-----