[TYPO3-core] RFC #7262: Fixing docheader in the backend modules

[Patrick Broens]

Hi Ingo,

Ingo Renner wrote:
> Patrick Broens wrote:
> 
> Hi Patrick,
> 
> ok, here we go after review and test...
> 
>> 20080205_rfc7262_base.diff: Base patch for template.php and 
>> stylesheet.css. Use this patch before applying any of the other patches.
> 
> * please leave the list module tables at 98% width or explain why you 
> want to reduce them to 93%
Back to 98%. Had some problems in the past with scrollbar, but this has 
been fixed differently
> * in template.php please use php5 access keywords (private, public, 
> protected)
Done
> * in moduleBody(): $markerArray -> $markers (name shouldn't contain a 
> hint that it is an array)
Done
> * docHeaderButtons() -> getDocHeaderButtons(), pagePath() -> 
> getPagePath(), pageInfo() -> getPageInfo()
Done
> * pagePath(), can the strong tag be avoided by using css?
Now with span and class
> 
> other than that: very good and clean
> 
>> 20080205_rfc7262_page.diff: Web > Page module
> 
> * JS is 90s style, not  yet prototype. but as we do not have the time 
> right now to clean this up and we also want to have something to do for 
> 4.3 this is ok for now =) I also guess that this stuff is not new, but 
> instead rather quite old
> * are you sure this is the right order:
> + $this->content.= $this->doc->endPage();
> + $this->content = $this->doc->insertStylesAndJS($this->content);
Actually, yes. This order is right
> 
>> 20080205_rfc7262_list.diff: Web > List module
> 
> * seems to be ok
> 
>> 20080205_rfc7262_info.diff: Web > Info module
> 
> * is ok
> 
>> 20080205_rfc7262_perm.diff: Web > Access module
> 
> * is ok
> 
>> 20080205_rfc7262_func.diff: Web > Functions module
> 
> * is ok
> 
>> 20080205_rfc7262_versioning.diff: Web > Versioning module
> 
> * is ok
> 
>> 20080205_rfc7262_template.diff: Web > Template module
> 
> * is ok
> 
> 
> for all patches in general:
> * rename $markerArray -> $markers
Done
> * use parameter type hits where possible, especially with array parameters
Done
> 
> 
> just change what I mentioned and then please commit
Committed to trunk

Patrick
> Ingo
>