[TYPO3-core] RFC Bug #7386: Remove hardcoded references to alt_main.php backend interface

Oliver Klee typo3-german-02 at oliverklee.de
Mon Feb 4 20:42:19 CET 2008


Hi,

+1 on reading if you fix the following nits:

+	 * Returns the name of the backend script relative to the TYPO3 main 
directory.
+	 *
+	 * @param	string		Optional name of the backend interface. If no 
interface is given, the interface for the current backend user is used.
+	 * @return	string
+	 */
+	public static function getBackendScript($interface = '') {

For the @param, please list the allowed values. "Optional name of the 
backend interface" could be improved a bit - currently the descriptions 
doesn't make clear what effect this variable has on the function's 
return value.

Please document the @return with a description in addition to the type.

+	public static function getBackendScript($interface = '') {
+		if(!$interface) {

Please add a space before the opening parenthesis.

+		switch($interface) {

Ditto.

+			case 'backend':
+			default:
+				$script = 'backend.php';
+				break;

Please add a line like "// The fall-through is intended." so that it's 
clear that the missing break isn't a programming error.

Regards,


Oliver


More information about the TYPO3-team-core mailing list