[TYPO3-core] RFC: #7370: Delete unused Marker in parsehtml::substituteMarkerArray

Martin Kutschker Martin.Kutschker at n0spam-blackbox.net
Mon Feb 4 19:19:35 CET 2008


Steffen Kamper schrieb:
> "Martin Kutschker" <Martin.Kutschker at n0spam-blackbox.net> schrieb im 
> Newsbeitrag 
> news:mailman.1.1202147880.25707.typo3-team-core at lists.netfielders.de...
> 
>> This CLI command worked for me
>> php -r
>>  'echo preg_replace("/#([A-Z0-9_-|]*)#/is","","a #b# cd #e# f"),"\n";'
>>
>>> Do you have a suggestion?
>> preg_replace returns the changed string, it doesn't change the argument.
>>
>> BTW, please use preg_quote() on the wraps.
>>
>> Masi
>>
>> PS: Also note that we here the example of the problematic strtoupper().
>> This will break Turkish sites (as it is affected by the locale). It should
>> be strtr('a...z','A..Z').
> 
> thank you Masi, now it works with one line. I also changed the strtoupper as 
> you suggested.
> New patch is attached.

+1 from reading. Another idea: please add a comment to the use of strtr 
like "strtr() instead of strtoupper() is used to avoid locale problems with 
Turkish)".

Masi


More information about the TYPO3-team-core mailing list