[TYPO3-core] RFC: #7337: stdWrap for menu > range & entrylevel

[Steffen Kamper]

"Michael Stucki" <michael at typo3.org> schrieb im Newsbeitrag 
news:mailman.1.1202029594.26813.typo3-team-core at lists.netfielders.de...
> Bernhard Kraft wrote:
>
>> Submitted to SVN.
>>
>> Georg: Are you taking care of changing the documentation?
>
> No, it's always the core developer who has to maintain the documentation
> right before committing the changes.
>
> Additionally, I see that the stdWrap for "range" has not been documented.
> Reading this discussion I see that Georg "thinks" that it is fine, however
> there is no mention of it on the Wiki page.
>
> Folks, please accept that documentation must gain the same high priority 
> like
> development has. If you are lazy about this, then you probably have to
> rethink if you want to be in the core team.
>
> I do my best to review changes like this one, but it seems likely that I
> overlook something, so we cannot rely on this!
>
>> I added the stdWrap for entryLevel also at another line in tslib_menu.php
>> so there is one more change in the commited version ...
>
> Hunk #2 is faulty:
>
> @@ -607,7 +607,7 @@
>                                                        $extraWhere.= ' AND 
> pages.no_search=0';
>                                                }
>                                                        // start point
> -                                               $eLevel = 
> tslib_cObj::getKey 
> (intval($this->conf['special.']['entryLevel']),$this->tmpl->rootLine);
> +                                               $eLevel = 
> tslib_cObj::getKey ($this->parent_cObj->stdWrap($conf['entryLevel'], 
> $conf['entryLevel.']),$this->tmpl->rootLine);
>                                                $startUid = 
> intval($this->tmpl->rootLine[$eLevel]['uid']);
>
>                                                        // which field is 
> for keywords
>
> I have reverted the commit and removed the documentation until it is 
> fixed.
>
> Sorry to be so dramatic, but the subject is important.
>
> - michael
> -- 

Hi Michael,

yes, it's wrong, should be
 $eLevel = tslib_cObj::getKey 
($this->parent_cObj->stdWrap($this->conf['special.']['entryLevel'], 
$this->conf['special.']['entryLevel.']),$this->tmpl->rootLine);

I agree to add this to documentation.
For this i have a suggestion: As I often look in documentation to find out 
if a property has stdWrap, it would make sense to mark the properties, eg
entryLevel <sup>*|*</sup>
This make it easy to recognize in one view which properties have the 
stdWrap, also to add the missing stdWrap features.

vg  Steffen