[TYPO3-core] RFC: #7265: Submodules of Web module can't work with mod.php and the _DISPATCH system

Dmitry Dulepov dmitry at typo3.org
Thu Dec 18 09:04:15 CET 2008


Hi!

Steffen Kamper wrote:
> v3 is attached.

This version works and looks ok to me. I would only add spaces on two lines where "theUrl" is used (change "parent.list_frame.location.href=theUrl;" to "parent.list_frame.location.href = theUrl;") to be consistent with the code two lines above. But since we do not have any conventions for JavaScript, I mention it only because of my personal taste :)

Thanks for the patch, Steffen! You have my +1!

-- 
Dmitry Dulepov
TYPO3 core team
In the blog: http://typo3bloke.net/post-details/how_will_i_fix_bugs_in_extensions_from_now_on/
My TYPO3 book: http://www.packtpub.com/typo3-extension-development/book


More information about the TYPO3-team-core mailing list