[TYPO3-core] RFC: Bug #8518: Wrong JavaScript inclusion in t3lib_TCEforms

Christian Kuhn lolli at schwarzbu.ch
Mon Aug 18 17:24:24 CEST 2008


Oliver Hader wrote:
> This is a SVN patch request.
> 
> Problem:
> There are superfluos inclusions of javascript resources in 
> t3lib_TCEforms. Thus, it might happen that prototype.js is defined in 
> the HEAD part of the document and again somewhere in the BODY.
> 
> Solution:
> Use template::loadJavascriptLib() to include a javascipt library only once.
> 
> Comments:
> Before this patch the JS libs where included somewhere in the BODY tag, 
> on using the mentioned function the libs will be included in the HEAD 
> tag now. However, this is no problem for the affected resources.
> The patch removes a superfluos inclusion of scriptaculous that was 
> introduced in rev. 2628 - scriptaculous is not required for the 
> functionalities of that SVN revision.
> Thanks to Benni Mack for writing the initial patch to utilize 
> template::loadJavascriptLib().
> 
> References:
> http://bugs.typo3.org/view.php?id=8518
> http://forge.typo3.org/repositories/diff/typo3v4-core?rev=2628
> 
> Branches: TYPO3_4-2, Trunk

+1 on reading and testing.

Attached patch re-adds the line break in $out.

Regards
Christian
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0008518_v4.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080818/2c218b2b/attachment.txt 


More information about the TYPO3-team-core mailing list