[TYPO3-core] RFC #9095: xhtml in the backend by default
Benjamin Mack
benni at typo3.org
Thu Aug 14 23:43:21 CEST 2008
Hey Christian,
awesome! Thanks for that. Just commited the patch to trunk (#3977), as
it is almost a non-functional change and we had quite a lot of "+1"s by
reading.
greetings,
benni.
-SDG-
Christian Kuhn wrote:
> Hi.
>
> Benjamin Mack wrote:
>> Hey all,
>>
>> this is a SVN patch request.
>>
>> Branches: trunk only
>>
>> Type: pure cleanup
>>
>> BT reference: http://bugs.typo3.org/view.php?id=9095
>>
>> Problem: Well, if you look at the code of the BE classes, you see that
>> there are many places where the template.php class is instantiated and
>> then the xhtml doktype is set. as we all agreed to have xhtml as
>> default, let's set this as default in template.html and get rid of all
>> the lines that clutter our code to make it easier to read and to
>> "not-have-to-think-about-adding-this-line" when coding new stuff.
>>
>> Solution:
>> Set the default in the switch/case to xhtml_trans and remove all the
>> occurences in the core where this is set manually.
>>
>> Notes:
>> This does not change any functionality for anything in the core and if
>> extensions still use this flag, nothing changes for them as well, it
>> just makes the core code more readable and more compact in my eyes.
>
> +1 on reading and testing.
>
> Attached a new patch to fix issues mentioned by Ernesto, Oliver and Dmitry:
> - Align break; with code in typo3/template.php
> - Fix comment of $docType in typo3/template.php
> - Add fallthrough comment to switch in typo3/template.php
> - Fixed a failing Hunk in typo3/alt_file_navframe.php
>
> Thanks
> Christian
More information about the TYPO3-team-core
mailing list