[TYPO3-core] RFC: #8152: Icons never created when noIconProc=0 and icon is present

[Steffen Kamper]

"Helmut Hummel" <typo3 at jhpc.de> schrieb im Newsbeitrag 
news:mailman.1.1208551771.11202.typo3-team-core at lists.netfielders.de...
> Hi Francois,
>
> Francois Suter wrote:
>>
>> Did you test your patch with the old skin by any chance? It simply
>> doesn't work.
>
> Well, yours do not work for me either ;)
>
>> The error is that when you call
>> t3lib_iconWorks::makeIcon() the 5th parameter ($absfile) is still set to
>> the value of the icon without skinning. To have the skinned icon as a
>> base, $absfile must contain an absolute path calculated with the skinned
>> icon path as a base. The enclosed patch corrects this.
>
> The problem starts earlier:
>
> if (@is_file(dirname($absfile).'/'.$iconFileName_stateTagged))
>
> checks, if there is a preprocessed icon, but it looks up in typo3/gfx... 
> and not
> in the path of the skin. If we want to change it, we must start there, 
> because
> if we leave it this way icons a processed, even if the skin has 
> preprocessed
> icons (which is waste of resources).
>

very good hint. After this i think i got it, please test the new patch.

What i did: i skinned the icon at the beginning, ommitting the backpath.
So i killed two birds with one stone - also preprocessed icons will be 
skinned now.

But with noIconProc=1 there is no fallback to old skin if there is no 
preprocessed icon, because the concept use the normal icon, process the 
flags and extend the iconname with the flags. There are two ways: preprocess 
the icons in skin or create a fallback in makeIcon.

vg Steffen 


begin 666 8152_noIconProc3.diff
M26YD97 at Z('0S;&EB+V-L87-S+G0S;&EB7VEC;VYW;W)K<RYP:' -"CT]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T-"BTM+2!T,VQI8B]C;&%S<RYT,VQI8E]I8V]N
M=V]R:W,N<&AP"2AR979I<VEO;B S-3DR*0T**RLK('0S;&EB+V-L87-S+G0S
M;&EB7VEC;VYW;W)K<RYP:' )*'=O<FMI;F<@8V]P>2D-"D! ("TQ-C,L-R K
M,38S+#$P($! #0H@"0EI9B H(7-T<G-T<B at D:6-O;F9I;&4L("<O)RDI('L*
M( D)"21I8V]N9FEL92 ]("=G9G at O:2\G+B1I8V]N9FEL93L*( D)?0HM"BL)
M"0HK"0D)+R\@<VMI;B!T:&4@:6-O;B!F:6QE"BL)"21I8V]N9FEL92 ]('0S
M;&EB7VEC;VY7;W)K<SHZ<VMI;DEM9R at G)RPD:6-O;F9I;&4L)R<L,2D["BL)
M"0D*( D)"2\O(%-E='1I;F<@=&AE(&%B<V]L=71E('!A=&@@=VAE<F4@=&AE
M(&EC;VX@<VAO=6QD(&)E(&9O=6YD(&%S(&$@9FEL93H*( D):68@*'-U8G-T
M<B at D:6-O;F9I;&4L(# L(#,I/3TG+BXO)RD@>PH@"0D))&%B<V9I;&4@/2!0
M051(7W-I=&4N<W5B<W1R*"1I8V]N9FEL92P@,RD["D! ("TR-#0L-R K,C0W
M+#<@0$ -"B )"0DD:6-O;D9I;&5.86UE7W-T871E5&%G9V5D(#T at 97)E9U]R
M97!L86-E*"<N*%M;.F%L;G5M.EU=*RDD)RP@)U]?)RXD9FQA9W,N)RY<,2<L
M(&)A<V5N86UE*"1I8V]N9FEL92DI.PH@"B )"0D)+R\@0VAE8VL@:68@=&%G
M9V5D(&EC;VX at 9FEL92!N86UE(&5X:7-T<R H82!T86=G970@:6-O;B!M96%N
M<R!T:&4@:6-O;B!B87-E(&YA;64@=VET:"!T:&4 at 9FQA9W, at 861D960@8F5T
M=V5E;B!B;V1Y(&%N9"!E>'1E;G-I;VX@;V8@=&AE(&9I;&5N86UE+"!P<F5F
M:7AE9"!W:71H('5N9&5R<V-O<F4I"BT)"0EI9B H0&ES7V9I;&4H9&ER;F%M
M92 at D86)S9FEL92DN)R\G+B1I8V]N1FEL94YA;65?<W1A=&5486=G960I*0E[
M"2\O($QO;VL at 9F]R(%MI8V]N;F%M95U?>'AX>"Y;97AT70HK"0D):68@*"1D
M;TYO=$=E;F5R871E26-O;B F)B! :7-?9FEL92AD:7)N86UE*"1A8G-F:6QE
M*2XG+R<N)&EC;VY&:6QE3F%M95]S=&%T951A9V=E9"DI"7L)+R\@3&]O:R!F
M;W(@6VEC;VYN86UE75]X>'AX+EME>'1="B )"0D)<F5T=7)N(&1I<FYA;64H
M)&EC;VYF:6QE*2XG+R<N)&EC;VY&:6QE3F%M95]S=&%T951A9V=E9#L*( D)
M"7T at 96QS96EF("@D9&].;W1'96YE<F%T94EC;VXI"7L)"2\O($EF(&YO(&EC
M;VX at 9V5N97)A=&EO;B!C86X at 8F4@9&]N92P@=')Y('1O(&QO;VL at 9F]R('1H
M92!?6"!I8V]N. at H@"0D)"21I8V]N1FEL94YA;65?6" ](&5R96=?<F5P;&%C
M92 at G+BA;6SIA;&YU;3I=72LI)"<L("=?7W at N7#$G+"!B87-E;F%M92 at D:6-O
M;F9I;&4I*3L*0$ @+3(U-"PW("LR-3<L-R! 0 T*( D)"0D)<F5T=7)N("=G
M9G at O:2]N;U]I8V]N7V9O=6YD+F=I9B<["B )"0D)?0H@"0D)?2!E;'-E('L)
M+R\@3W1H97)W:7-E+"!C<F5A=&4@=&AE(&EC;VXZ"BT)"0D))'1H95)E<R ]
M('0S;&EB7VEC;VY7;W)K<SHZ;6%K94EC;VXH)$=,3T)!3%-;)T)!0TM?4$%4
M2"==+B1I8V]N9FEL92P@)'-T<FEN9RP@)'5S97(L("1P<F]T96-T4V5C=&EO
M;BP@)&%B<V9I;&4L("1I8V]N1FEL94YA;65?<W1A=&5486=G960I.PHK"0D)
M"21T:&5297,@/2!T,VQI8E]I8V]N5V]R:W,Z.FUA:V5)8V]N*"1I8V]N9FEL
M92P@)'-T<FEN9RP@)'5S97(L("1P<F]T96-T4V5C=&EO;BP@)&%B<V9I;&4L
M("1I8V]N1FEL94YA;65?<W1A=&5486=G960I.PH@"0D)"7)E='5R;B D=&AE
M4F5S.PH@"0D)?0H@"0E](&5L<V4@>PI 0" M-3(R+#0@*S4R-2PT($! #0H@
M"0E]"B )?0H@?0HM/SX-"EP at 3F\@;F5W;&EN92!A="!E;F0@;V8 at 9FEL90T*
$*S\^"@``
`
end