[TYPO3-core] RFC: #8092: defect wsid check in workspace-overlay delivering wrong record versions from DB!

[Franz Koch]

Hi Masi,

>> correct the operator in the if-statement of the wsid-check from '!==' 
>> to '!='. Patch is provided in bugreport.
> 
> Why is this the solution? The original check assumed that wsid is an 
> integer. After your change an implict type conversion occurs.

if '!=' should not be used when checking the wsid - then there is 
another bug in core where exactly this is the case. See method 
t3lib_befunc::workspaceOL itself (line 3518 of current 4.2 branch: if 
($wsid!=0 && is_array($row)).

Oh, and line 147 of class.wslib.php ($stage!=-99) :)

So this should be changed too, I guess.

--
kind regards,
Franz