[TYPO3-core] RFC: #6670: Enable Tabs in Page Properties III
Benjamin Mack
benni at typo3.org
Tue Apr 8 13:33:40 CEST 2008
Hey guys,
just had a first quick peek in the patch.
#1. Please use "array(" instead of "Array ("
#2. You change language labels. AFAIK this is not allowed, but I do like
your change with the "Exclude from search".
@Dmitry: What can we do here? is this an exception or how can we proceed
here? I'm cool with changing it in all TYPO3 versions :)
#3 Thanks for adding the CSH for fe_login_mode. It really bothered me.
This part has a straight +1 from my side :)
#4 You have some strange tabbing and line-breaking in your patch
==========
+ $types_default .
+ $types_title .
+ $types_subtitle .
+ $types_nav .
==========
+ $types_files = '--div--;LLL:EXT:cms/locallang_tca.xml:pages.tabs.files,
+ media,';
==========
intentional?
I'll check on functionality within the next days. Please send a new
patch to the initial RFC so we know where we're at, this thread is
really huge now :)
--
greetings,
benni.
-SDG-
More information about the TYPO3-team-core
mailing list