[TYPO3-core] RFC: Fix #1537: Shortcut icon syntax incorrect/incomplete

[Ingmar Schlecht]

+1 by reading.

Just one little comment:

Please change:
    $favIcon = 
$GLOBALS['TSFE']->tmpl->getFileName($GLOBALS['TSFE']->pSetup['shortcutIcon']);
    $favIcon = t3lib_div::getIndpEnv('TYPO3_SITE_URL').$favIcon;

into:
    $favIcon = 
t3lib_div::getIndpEnv('TYPO3_SITE_URL').$GLOBALS['TSFE']->tmpl->getFileName($GLOBALS['TSFE']->pSetup['shortcutIcon']);

cheers
Ingmar


Michael Stucki schrieb:
> This is a SVN patch request.
> 
> Problem:
> page.shortcutIcon adds this to the page:
>  
>  <link rel="SHORTCUT ICON" href="(whatever path was set in the template)" />
> 
> This is not working in MSIE, which is why an additional line is needed:
> 
>  <link rel="icon" href="..." type="image/x-icon" />
>  <link rel="shortcut icon" href="..." type="image/x-icon" />';
> 
> Solution:
> Add this new line, additionally append the MIME type, if found.
> I also decided to prefix the icon with the TYPO3_SITE_URL because apparently
> MSIE also ignores the base URL when reading this icon... (nice browser,
> isn't it?)
> 
> Branches: TYPO3_4-2
> 
> Bugtracker reference:
> http://bugs.typo3.org/view.php?id=1537
> 
> Comments:
> In some environments you might need to apply an additional patch
> (see issue #1007) to test this.
> 
> Thanks to Sören Schaffstein who sponsored this bug as part of the bug
> auction at T3BOARD08 :-)
> 
> - michael
> 


-- 
Ingmar Schlecht
TYPO3 Association Active Member