[TYPO3-core] RFC: minify JavaScript

Dmitry Dulepov [typo3] dmitry at typo3.org
Thu Sep 13 13:47:42 CEST 2007


Hi!

Ernesto Baschny [cron IT] wrote:
> Attached is a patch which will also externalize (and optionally minify)
> the "openPic", "over" and "out" (mouseOver) and any other
> "additionalJavaScript". I wonder if this is too risky, as there might be
> dynamic javascript in there coming from extensions
> (additionalJavaScript), which would pollute the typo3temp. I left out
> JSImgCode on purpose, but we could add that too to this process.
> 
> Opinios?

+1. One very small correction to this line:

--------------
$_scriptCode = 
implode(chr(10),$this->additionalJavaScript)."\n".trim($this->JSCode);
--------------

It uses both "\n" and chr(10). May be better chr(10) in all places.

-- 
Dmitry Dulepov
TYPO3 freelancer / TYPO3 core team member
Web: http://typo3bloke.net/
Skype: callto:liels_bugs


More information about the TYPO3-team-core mailing list