[TYPO3-core] RFC: Feature #2883 / t3lib_div::trimExplode

Martin Kutschker Martin.Kutschker at n0spam-blackbox.net
Fri Sep 7 14:39:51 CEST 2007


Michael Stucki schrieb:
> Hi Martin,
> 
>>> you already got two +1 for that
>> Wasn't sure which version got the +1.
>>
>> I have commited mine now.
> 
> Thanks so far! I was just wondering if there is a reason for keeping
> redundant code inside the function?

Speed. The "if ($onlyNonEmptyValues)" needs only to be executed once) and 
mind the array_merge() which is only necessary (to reindex the array) when 
$onlyNonEmptyValues is set.

Please, don't "beautify". Then we could have lived with the old code.

Masi


More information about the TYPO3-team-core mailing list