[TYPO3-core] RFC: Feature #4064 - Navigation title in tree view

[Martin Kutschker]

Thomas Hempel schrieb:
> Hi,
> 
>>>> I thought of this when I wrote the last patch version. I will add that.
>>> See patch version 4 attached to this post.
>>>
>>> This is applicable for most recent trunk (after Kaspers patches).
>>
>> The patch still contains a few bugs:
>>
>> 1. you "fixed" the wrong "labele" into "lable", but "label" would be 
>> correct
> Oops. You're right. I changed that.
> 
> 
>>
>> 2. t3lib_div::fixed_lgd_cs($row['nav_title'],$titleLen)
>>    => all output of this function must be htmlspecialchar'ed (occurs more
>>       than only once!)
> I added that.
> 
> See patch version 5 attached to this post. I hope this is the final one 
> now.

Looks ok, but untested: +1

BTW, how many ways do we use to test for an empty string?

The code has this one:

(strlen(trim($row['title'])) == 0)

I prefer this:

$var === ''

but as trim returns a string trim($row['title'])=='' would be save.

Elsewhere we have this:

strcmp($var,'')

Masi