[TYPO3-core] RFC: #6259 Disabling Tabs with no fields (does not work)

[Malte Jansen]

Hi Ingmar,

here is the screenshot for for the different versions....
(I have removed some tables, but the importend part should be clear)
Disabled (empty) tabs are labeled with "Sonstiges" and "Verein XXX".


Here some Comments for an easy validation.

class.t3lib_tceforms.php
Lines 642ff:
- Content should only be wrapped if implodded $sheetContent is not 
empty. (Otherwise the in the template.php does not work; This was the 
Main bug/Problem).

template.php
Lines ~1735ff
- The Condition has to be remove (if ($isActive) {..}), otherwise the 
empty tab is not shown. (There are still some other Condition with 
($isActive ? ... : ...), which were there before and work fine)
Lines ~1853ff
- Only Overriding the class of the div-tab, when tab not disabled, 
otherwise they would get the same layout.

typo3-dyntabmenu.css
- Should be clear from the picture (adding some padding and border)

So, it should be easier for you to check. Because there are only ~6 
lines of code changed.

Malte


Ingmar Schlecht schrieb:
> Hi Malte,
> 
> Malte Jansen schrieb:
>> The essence of the patch are only 6-7 lines. The rest is removing tabs
>> for the code-style...
> 
> Which lines are that?
> 
> Could you post screenshots of what it looked like before/after?
> 
> cheers
> Ingmar

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 07-10-28_t3_tabs.jpg
Type: image/jpeg
Size: 61024 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071028/64ce4f6d/attachment-0001.jpg