[TYPO3-core] RFC: #4662 PAGE_TARGET =

[Ernesto Baschny [cron IT]]

Hi,

the patch doesn't apply very cleanly because of these

-
 ?>
\ No newline at end of file

parts. Maybe you could check on that? Other than that, just fix the
version for the compat-version change:

+    'version' => 4200000,

should be:

+    'version' => 4002000,

Then its a +1 from me.

Cheers,
Ernesto


Steffen Kamper wrote: on 24.10.2007 18:32:
> *maybe final version*
> 
> This is a SVN patch request.
> 
> Type: ENHANCEMENT
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=4662
> 
> 
> Branches:
> Trunk
> 
> typo3/sysext/css_styled_content/static/constants.txt
> typo3/sysext/css_styled_content/static/setup.txt
> typo3/sysext/css_styled_content/ext_localconf.php
> 
> Problem:
> 
> default setting for PAGE_TARGET is page. This is an old setting for frames,
> nowadays it's obsolete.
> Second tt_content.menu uses as target pageFrameObj which is obsolete too.
> 
> Solution:
> 
> setting in CONSTANTS:
> [compatVersion = 4.2.0]
> PAGE_TARGET =
> content.pageFrameObj >
> [end]
> 
> setting in SETUP
> [compatVersion = 4.2.0]
> tt_content.menu.20.default.1.target = {$PAGE_TARGET}
> tt_content.menu.20.2.1.target = {$PAGE_TARGET}
> [end]
> 
> remarks for update wizard
> 
> $TYPO3_CONF_VARS['SC_OPTIONS']['ext/install']['compat_version']['tx_cssstyledcontent_pagetargets'] 
> = array(
>     'title' => 'CSS Styled Content: Default targets for non-frame pages',
>     'version' => 4200000,
>     'description' => '<p>The default page target is empty (so no target is 
> generated). If you use frames, you have to set it to page in Constants.</p>'
> );
> 
> 
> Notes:
> like to have defaults to the settings 99% of the users need.
> 
> Link generation has as defaults (tslib_content)
> intTarget =
> extTarget = _top
> 
> which can be leaved unchanged (IMHO)
> 
> Steffen
> 
> 
> --------------------------------------------------------------------------------
> 
> 
> 
>