[TYPO3-core] RFC: #6259 Disabling Tabs with no fields (does not work)

Malte Jansen mail at maltejansen.de
Wed Oct 24 22:56:25 CEST 2007


Some further information...

The essence of the patch are only 6-7 lines. The rest is removing tabs 
for the code-style...

Malte

Malte Jansen schrieb:
> 
> 
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=6259
> 
> Branches:
> Trunk & 4.1
> 
> Problem:
> Disabling Tabs with no fields does not work
> because the check (in template.php) is never true, because the parameter 
> is never empty because of a table-wrap in the class.t3lib_tceforms.php
> 
> Solution:
> The table-wrap should only be done, when there is somesthing to wrap.
> (See Bug)
> 
> Notes:
> The original of disabling the Tabs is still coded, but an other 
> additional check was added, which uses $isActive (template.php) in a 
> wrong content for removing empty tabs.
> One way would be rename the var. The other way is using it in the 
> original meaning.
> An additional feature could be the removing of empty tabs. But as 
> default they should only be disabled, because if you have several tabs, 
> they would jump over lines and you would loose the overview. So 
> disabling tabs should be discussed somewhere (perhaps it is an option to 
> use it as divs2tabs => 2)...
> 
> 
> Addinitional Modification:
> - Change in t3skin, because of the wrong css-class name, the style does 
> not work correct and a missing border.
> - in template.php: Overriding the class of disabled tabs is corrected in 
>  JavaSript-Part
> 
> I hope have followed all rules ;)
> 
> 
> Malte Jansen
> 


More information about the TYPO3-team-core mailing list