[TYPO3-core] RFC: #4662 PAGE_TARGET = *compat version

[Steffen Kamper]

Hi Ernesto,

"Ernesto Baschny [cron IT]" <ernst at cron-it.de> schrieb im Newsbeitrag 
news:mailman.1.1193168100.3068.typo3-team-core at lists.netfielders.de...
> Hi Steffen,
>
> thanks for the enhancement!
>
> Steffen Kamper wrote: on 23.10.2007 21:26:
>
>> This is a SVN patch request.
>>
>> Type: ENHANCEMENT
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=4662
>> (...)
>> Second tt_content.menu uses as target pageFrameObj which is obsolete too.
>>
>> Solution:
>> setting in CONSTANTS
>> [compatVersion = 4.2.0]
>> PAGE_TARGET =
>> [end]
>>
>> setting in tt_content.menu
>> all targets to {$PAGE_TARGET}
>
> This second change might break existing installations. If we want to
> guarantee the holy-cow it has to be consistent. So you also need a
> [compatVersion] around that change:

ok, you're right, i will do.

>
>> Index: typo3/sysext/css_styled_content/static/setup.txt
>> ===================================================================
>> --- typo3/sysext/css_styled_content/static/setup.txt (revision 2611)
>> +++ typo3/sysext/css_styled_content/static/setup.txt (working copy)
>> @@ -904,7 +904,7 @@
>>     1 = TMENU
>>     1.NO.allWrap = <p>|</p>
>>     1.NO.stdWrap.htmlSpecialChars = 1
>> -   1.target = {$content.pageFrameObj}
>> +   1.target = {$PAGE_TARGET}
>>    }
>>
>>    # "Menu of subpages to these pages"
>> @@ -919,7 +919,7 @@
>>     1 = TMENU
>>     1.NO.allWrap = <p class="csc-sitemap csc-sitemap-level1">|</p>
>>     1.NO.stdWrap.htmlSpecialChars = 1
>> -   1.target = {$content.pageFrameObj}
>> +   1.target = {$PAGE_TARGET}
>>     1.expAll = 1
>>
>>     2 < .1
>
> Else everybody which have set the constant "content.pageFrameObj" and
> want to keep "backwards mode" (compat_version set to < 4.2) won't get
> that constant honored anymore.
>
> I would suggest cleaning up the constant content.pageFrameObj in
> constants.txt (in the [compatVersion = 4.2] section) and changing the
> "1.target = " settings in menus also in a [compatVersion = 4.2] section
> to {$PAGE_TARGET}.
>
> What do you think?
>
> Cheers,
> Ernesto

that would result that there is no pageFrameObj in compat version >=4.2
For me it's fine, as there still is PAGE_TARGET if anyone want to use 
frames.

So i have 2 additional questions:
1) should i write in compat(setup.txt) the complete tt_content.menu-object 
or just the 2 lines which changed ?
2) How to clean up constant content.pageFrameObj in compat ?

vg  Steffen