[TYPO3-core] RFC: fix bug: 6561 imgMax and imgStart (IMGTEXT) not working properly

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Sun Oct 21 12:24:02 CEST 2007


Helmut Hummel schrieb:
> Hi Ingmar,
> 
> Ingmar Schlecht schrieb:
>> I've committed the fix for the missing stdWrap of imgMax (see attached
>> patch) to trunk and TYPO3_4-1 because it's an obvious no-brainer.
> 
> Thx.
> 
>> I didn't review/test the other part of the patch. So can you send a new
>> patch that only fixes the wrong index key problem?
> 
> Here it is. I've tested it properly and it works fine for me.

Ok, I checked the code of CSC:

It seems that unlike the original cObject IMGTEXT CSC uses $imgsTag 
later on with base index of 0 (eg uses count() on the array). So the 
patch is fine: +1 reviewing (no test).

Maybe you can add to $imgsTag = array() the following comment:

// array index 0 is the first shown image

Masi


More information about the TYPO3-team-core mailing list