[TYPO3-core] RFC: Fix Bug #6531 - Function getUpdateJS doesn't work properly
Ingmar Schlecht
ingmar at typo3.org
Sat Oct 20 19:45:35 CEST 2007
Hi Thomas,
Thomas Hempel schrieb:
> Index: .
> ===================================================================
> --- . (revision 2587)
> +++ . (working copy)
> @@ -6072,6 +6072,7 @@
> function getUpdateJS($dataArray, $formName, $arrPrefix, $fieldList) {
> $JSPart='';
> $updateValues=t3lib_div::trimExplode(',',$fieldList);
> + reset($updateValues);
> while(list(,$fKey)=each($updateValues)) {
> $value = $dataArray[$fKey];
> if (is_array($value)) {
+1 to the above patch, please just commit this nobrainer.
The other patch you sent seems a little unclean to me.
- Why did you add the additional "[]" in the JS lines without
describing it in the patch description?
- The change to foreach shouldn't be done for 4.1.
As the simple addition of reset() fixes the problem easily, please just
commit that.
cheers
Ingmar
More information about the TYPO3-team-core
mailing list