[TYPO3-core] RFC: Move the BE logo generation code into a separate method so it can be used from other classes
Benjamin Mack
mack at xnos.org
Wed Oct 17 12:48:46 CEST 2007
Hi Ingo,
IMHO the new created function should be separated from the rendering of
the page. I don't like the
if (!$GLOBALS['includeClassOnly']) {
use.
What about creating a "class.logo.php" that goes in the typo3/classes
or the typo3/include directory (where all new classes should be stored
anyways, to clean up the typo3/ directory :) ) ?
OK. so +1 for the idea, and also since we really need it.
Put the class in a separate file, include it and the alt_toplogo.php is
almost only a stub to only include the class file and instantiate it -
that's what I'd call a clean up.
greetings,
benni.
-SDG-
www.xnos.de // www.xnos.org
Ingo Renner wrote:
> Hi *,
>
> This is an SVN patch request.
>
> Type: cleanup
>
> Problem:
> Currently the logo in the BE is generated by alt_toplogo.php resulting
> in a whole html document. This makes it impossible to reuse that code
> from another class.
>
> Solution:
> move logo generation into separate public static function.
>
>
> Notes:
> This is change is required for the revised BE, otherwise we'd need to
> deal with duplicate code.
>
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=6539
>
> Branches:
> trunk only
>
>
> Ingo
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core
More information about the TYPO3-team-core
mailing list